Issue 69933005: Revert "linux: use CLOCK_{REALTIME,MONOTONIC}_COARSE"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 69933005: Revert "linux: use CLOCK_{REALTIME,MONOTONIC}_COARSE" (Closed)

Created:
7 years, 1 month ago by Jakob Kummerow

Modified:
7 years, 1 month ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert "linux: use CLOCK_{REALTIME,MONOTONIC}_COARSE" This reverts r17642 (and follow-up fix r17644) for crashing the Chrome sandbox. TBR=bmeurer@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17668

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -59 lines)			Patch
	M	src/platform/time.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	src/platform/time.cc	View		3 chunks	+1 line, -57 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

Committed patchset #1 manually as r17668 (presubmit successful).

7 years, 1 month ago (2013-11-12 17:10:40 UTC) #1

bnoordhuis

On 2013/11/12 17:10:40, Jakob wrote: > Committed patchset #1 manually as r17668 (presubmit successful). Can ...

7 years, 1 month ago (2013-11-12 17:30:43 UTC) #2

Jakob Kummerow

On 2013/11/12 17:30:43, bnoordhuis wrote: > On 2013/11/12 17:10:40, Jakob wrote: > > Committed patchset ...

7 years, 1 month ago (2013-11-12 17:33:58 UTC) #3

Benedikt Meurer

7 years, 1 month ago (2013-11-13 10:29:00 UTC) #4

Message was sent while issue was closed.

On 2013/11/12 17:33:58, Jakob wrote:
> On 2013/11/12 17:30:43, bnoordhuis wrote:
> > On 2013/11/12 17:10:40, Jakob wrote:
> > > Committed patchset #1 manually as r17668 (presubmit successful).
> > 
> > Can you define 'crash'?  Is Chrome's seccomp2 filter rejecting the system
> calls?
> 
> Yes. See http://goo.gl/BgKWLU and other buildbot runs from around that
revision.
> 
> It's easy to repro those crashes in a local Chromium build.

LGTM

Expand Messages | Collapse Messages