Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Issue 699313006: Add benchmark to compare different BBH query patterns. (Closed)

Created:
6 years, 1 month ago by mtklein_C
Modified:
6 years, 1 month ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add benchmark to compare different BBH query patterns. On my laptop: maxrss loops min median mean max stddev samples config bench 37M 1 14ms 14.2ms 14.6ms 18.2ms 9% ▁█▁▁▁▁▂▂▂▁ gpu tiled_playback_tilegrid_tiled 40M 1 17ms 17.2ms 17.2ms 17.6ms 1% ▆▃▁█▄▇▂▁▁▁ gpu tiled_playback_tilegrid_random 40M 1 14.6ms 14.9ms 15.8ms 19.1ms 11% ▂▁▁▁▁▁▁█▅█ gpu tiled_playback_rtree_tiled 43M 1 16.5ms 16.7ms 16.8ms 17.4ms 1% ▂▃▅█▃▂▁▃▃▂ gpu tiled_playback_rtree_random 43M 1 15.9ms 16.1ms 16.5ms 18.7ms 6% ▁▁█▇▁▁▁▂▁▁ gpu tiled_playback_none_tiled 44M 1 17.9ms 17.9ms 18ms 18.1ms 1% ▂▁▅▁▇▃▁▂█▇ gpu tiled_playback_none_random TileGrid and RTree perform pretty much the same, both beating no BBH. BUG=skia:3085 Committed: https://skia.googlesource.com/skia/+/bf5dd4170ffe2b3858280c233caf2053ee47c2c7

Patch Set 1 #

Total comments: 3

Patch Set 2 : break #

Total comments: 4

Patch Set 3 : comment #

Patch Set 4 : zero xy #

Patch Set 5 : scalars #

Patch Set 6 : windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -0 lines) Patch
M bench/PicturePlaybackBench.cpp View 1 2 3 4 5 2 chunks +83 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (8 generated)
mtklein
6 years, 1 month ago (2014-11-07 16:02:13 UTC) #2
robertphillips
https://codereview.chromium.org/699313006/diff/1/bench/PicturePlaybackBench.cpp File bench/PicturePlaybackBench.cpp (right): https://codereview.chromium.org/699313006/diff/1/bench/PicturePlaybackBench.cpp#newcode169 bench/PicturePlaybackBench.cpp:169: case kRTree: factory.reset(new SkRTreeFactory); break; ? https://codereview.chromium.org/699313006/diff/1/bench/PicturePlaybackBench.cpp#newcode170 bench/PicturePlaybackBench.cpp:170: case ...
6 years, 1 month ago (2014-11-07 18:29:39 UTC) #3
mtklein
https://codereview.chromium.org/699313006/diff/1/bench/PicturePlaybackBench.cpp File bench/PicturePlaybackBench.cpp (right): https://codereview.chromium.org/699313006/diff/1/bench/PicturePlaybackBench.cpp#newcode169 bench/PicturePlaybackBench.cpp:169: case kRTree: factory.reset(new SkRTreeFactory); On 2014/11/07 18:29:39, robertphillips wrote: ...
6 years, 1 month ago (2014-11-07 18:45:28 UTC) #4
mtklein
On 2014/11/07 18:45:28, mtklein wrote: > https://codereview.chromium.org/699313006/diff/1/bench/PicturePlaybackBench.cpp > File bench/PicturePlaybackBench.cpp (right): > > https://codereview.chromium.org/699313006/diff/1/bench/PicturePlaybackBench.cpp#newcode169 > ...
6 years, 1 month ago (2014-11-07 18:49:45 UTC) #5
robertphillips
lgtm + a dox suggestion & a question. I'm surprised the difference for non-1-1 hits ...
6 years, 1 month ago (2014-11-07 18:59:59 UTC) #6
mtklein
https://codereview.chromium.org/699313006/diff/20001/bench/PicturePlaybackBench.cpp File bench/PicturePlaybackBench.cpp (right): https://codereview.chromium.org/699313006/diff/20001/bench/PicturePlaybackBench.cpp#newcode146 bench/PicturePlaybackBench.cpp:146: enum Mode { kTiled, kRandom }; On 2014/11/07 18:59:59, ...
6 years, 1 month ago (2014-11-07 19:05:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/699313006/40001
6 years, 1 month ago (2014-11-07 19:06:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot/builds/502) Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/681)
6 years, 1 month ago (2014-11-07 19:07:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/699313006/50001
6 years, 1 month ago (2014-11-07 19:16:28 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/683)
6 years, 1 month ago (2014-11-07 19:19:36 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/699313006/70001
6 years, 1 month ago (2014-11-07 19:24:29 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/691)
6 years, 1 month ago (2014-11-07 19:35:08 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/699313006/90001
6 years, 1 month ago (2014-11-11 18:31:42 UTC) #21
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 18:39:31 UTC) #22
Message was sent while issue was closed.
Committed patchset #6 (id:90001) as
https://skia.googlesource.com/skia/+/bf5dd4170ffe2b3858280c233caf2053ee47c2c7

Powered by Google App Engine
This is Rietveld 408576698