Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 699283003: DFText: fix placement of glyphs when we fall back to paths (Closed)

Created:
6 years, 1 month ago by jvanverth1
Modified:
6 years, 1 month ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

DFText: fix placement of glyphs when we fall back to paths Rendering a glyph with a path wants to place it at the (sx, sy) we get as input to the method, but we add (dx, dy) for the clipRect check. Hence, we need to subtract that out before we render the path. Committed: https://skia.googlesource.com/skia/+/0e66aaa503fd30b9860c0306ae20e8d7758b0fe6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/gpu/GrDistanceFieldTextContext.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
jvanverth1
6 years, 1 month ago (2014-11-04 21:20:28 UTC) #2
robertphillips
lgtm
6 years, 1 month ago (2014-11-04 21:22:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/699283003/1
6 years, 1 month ago (2014-11-04 21:23:17 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 21:32:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 0e66aaa503fd30b9860c0306ae20e8d7758b0fe6

Powered by Google App Engine
This is Rietveld 408576698