Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 699233002: Revert disable of SDCH on iOS. (Closed)

Created:
6 years, 1 month ago by Randy Smith (Not in Mondays)
Modified:
6 years, 1 month ago
Reviewers:
droger
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert disable of SDCH on iOS. BUG=418975 R=droger@chromium.org Committed: https://crrev.com/8290aa0050bc527c740ae84e0267f79abc9cb0ce Cr-Commit-Position: refs/heads/master@{#302879}

Patch Set 1 #

Patch Set 2 : Fix HTTPS support test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M net/base/sdch_manager.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M net/base/sdch_manager_unittest.cc View 1 3 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Randy Smith (Not in Mondays)
David: Could you review this for me? I'm looking as much for the process review ...
6 years, 1 month ago (2014-11-04 19:17:34 UTC) #1
droger
Lgtm I don't know if this can land on M40 (I think branch point is ...
6 years, 1 month ago (2014-11-04 19:46:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/699233002/20001
6 years, 1 month ago (2014-11-05 20:05:54 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-05 21:54:53 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 21:56:13 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8290aa0050bc527c740ae84e0267f79abc9cb0ce
Cr-Commit-Position: refs/heads/master@{#302879}

Powered by Google App Engine
This is Rietveld 408576698