Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Issue 699203003: msvs: Fix rule dependencies for VS2013 (Closed)

Created:
6 years, 1 month ago by Shezan Baig (Bloomberg)
Modified:
6 years, 1 month ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

msvs: Fix rule dependencies for VS2013 This commit does two things to fix rules for VS2013: * Don't exclude rule 'input' files (i.e. the files that will be used as 'AdditionalDependencies' in the msbuild rule definition). * Use a 'CustomBuild' element for 'AdditionalDependencies' files, instead of using 'None'. This is similar to how the primary input of actions is added in '_AddMSBuildAction'. Also, re-enable the test/rules-rebuild/gyptest-default.py test for VS2013. BUG=gyp:465 R=scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1997

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -31 lines) Patch
M pylib/gyp/generator/msvs.py View 18 chunks +38 lines, -23 lines 0 comments Download
M test/rules-rebuild/gyptest-default.py View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Shezan Baig (Bloomberg)
I ran the test on both VS2010 and VS2013 locally, and this change seems to ...
6 years, 1 month ago (2014-11-04 20:11:49 UTC) #2
Shezan Baig (Bloomberg)
The mac failure doesn't seem related to this patch at all
6 years, 1 month ago (2014-11-04 20:24:41 UTC) #3
scottmg
Thanks! LGTM.
6 years, 1 month ago (2014-11-04 21:30:51 UTC) #4
Shezan Baig (Bloomberg)
6 years, 1 month ago (2014-11-04 22:57:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 1997 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698