Issue 6992025: WIP: Blocks for global handles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6992025: WIP: Blocks for global handles.

Created:
9 years, 7 months ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

WIP: Blocks for global handles. R=vegorov@chromium.org

Patch Set 1 #

Total comments: 2

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+312 lines, -308 lines)			Patch
M	src/global-handles.h	View	2 chunks	+8 lines, -28 lines	0 comments	Download
M	src/global-handles.cc	View	17 chunks	+302 lines, -280 lines	2 comments	Download
M	src/utils.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

9 years, 7 months ago (2011-05-24 16:45:12 UTC) #1

I like it. Seems to be much cleaner then before (especially because there is no
free/deallocated duality).

I am a bit concerned about fragmentation which might negatively affect iteration
performance though.

http://codereview.chromium.org/6992025/diff/1/src/global-handles.cc
File src/global-handles.cc (right):

http://codereview.chromium.org/6992025/diff/1/src/global-handles.cc#newcode397
src/global-handles.cc:397: new NodeBlock(this);
Personally I don't like constructors with deep implicit side effects.

http://codereview.chromium.org/6992025/diff/1/src/global-handles.cc#newcode510
src/global-handles.cc:510: if (collector == SCAVENGER &&
!it.node()->is_independent()) continue;
Interesting: so skipping blocks with no young independent handles here does not
win us anything, does it?

Expand Messages | Collapse Messages