Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 699173003: Makes ViewManagerServiceImpl track a single root (Closed)

Created:
6 years, 1 month ago by sky
Modified:
6 years, 1 month ago
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Makes ViewManagerServiceImpl track a single root Code allowed for a set of roots, but that is no longer possible. BUG=none TEST=none R=ben@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a8ca772c9156218afda0f53a86284015da0b7212

Patch Set 1 #

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -85 lines) Patch
M mojo/services/view_manager/access_policy_delegate.h View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/services/view_manager/connection_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/view_manager/default_access_policy.h View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/services/view_manager/default_access_policy.cc View 5 chunks +10 lines, -12 lines 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.h View 1 5 chunks +9 lines, -20 lines 0 comments Download
M mojo/services/view_manager/view_manager_service_impl.cc View 9 chunks +33 lines, -45 lines 0 comments Download
M mojo/services/view_manager/window_manager_access_policy.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sky
6 years, 1 month ago (2014-11-06 18:45:46 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 1 month ago (2014-11-06 20:13:37 UTC) #2
sky
6 years, 1 month ago (2014-11-06 20:43:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a8ca772c9156218afda0f53a86284015da0b7212 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698