base/sys_info_unittest.cc - Issue 699173002: UMA: Set Hardware model class on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/sys_info_unittest.cc

Issue 699173002: UMA: Set Hardware model class on Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix review comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/sys_info_unittest.cc

diff --git a/base/sys_info_unittest.cc b/base/sys_info_unittest.cc

index 29409eed340c0af2f93e8419b054b04fbd0eca1e..ddb47fa0c063663bf9f1a25f36f2e11e0be01ff7 100644

--- a/base/sys_info_unittest.cc

+++ b/base/sys_info_unittest.cc

@@ -65,6 +65,13 @@ TEST_F(SysInfoTest, Uptime) {

EXPECT_GT(up_time_2, up_time_1);

}

+#if defined(OS_MACOSX)

+TEST_F(SysInfoTest, HardwareModelName) {

+ std::string hardware_model = base::SysInfo::HardwareModelName();

+ EXPECT_FALSE(hardware_model.empty());

+#endif

#if defined(OS_CHROMEOS)

TEST_F(SysInfoTest, GoogleChromeOSVersionNumbers) {