UMA: Set Hardware model class on Mac.

base/sys_info.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_SYS_INFO_H_
 #define BASE_SYS_INFO_H_
 
 #include <map>
 #include <string>
 
@@ skipping 33 matching lines @@
     return static_cast<int>(AmountOfVirtualMemory() / 1024 / 1024);
   }
 
   // Return the available disk space in bytes on the volume containing |path|,
   // or -1 on failure.
   static int64 AmountOfFreeDiskSpace(const FilePath& path);
 
   // Returns system uptime in milliseconds.
   static int64 Uptime();
 
+  // Returns a descriptive string for the current machine model or "Unknown"

[Alexei Svitkine (slow), 2014/11/04 16:22:12]

Maybe better to return an empty string if unknown?

[jeremy, 2014/11/05 05:38:06]

Done.

+  // if an error occured.

[Alexei Svitkine (slow), 2014/11/04 16:22:12]

Can you provide an example of a return value in the comment?

Also, mention which platforms it's implemented on.

[jeremy, 2014/11/05 05:38:06]

Example added.
I've never seen us mention supported platforms in a header comment before - if
you think I should, I have no problem adding it :)

[Alexei Svitkine (slow), 2014/11/05 15:47:21]

My preference would be to add it - as it's helpful to users of the API when
they're looking at the header file. Less surprises, etc.

+  static std::string HardwareModelName();
+
   // Returns the name of the host operating system.
   static std::string OperatingSystemName();
 
   // Returns the version of the host operating system.
   static std::string OperatingSystemVersion();
 
   // Retrieves detailed numeric values for the OS version.
   // TODO(port): Implement a Linux version of this method and enable the
   // corresponding unit test.
   // DON'T USE THIS ON THE MAC OR WINDOWS to determine the current OS release
@@ skipping 68 matching lines @@
 
   // Returns true if this is a low-end device.
   // Low-end device refers to devices having less than 512M memory in the
   // current implementation.
   static bool IsLowEndDevice();
 };
 
 }  // namespace base
 
 #endif  // BASE_SYS_INFO_H_