Issue 699153003: Make codereview.settings ready for git.

Issue 699153003: Make codereview.settings ready for git. (Closed)

Created:
6 years, 1 month ago by Michael Achenbach

Modified:
6 years, 1 month ago

Reviewers:
agable, tandrii(chromium)

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	codereview.settings	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 8 (2 generated)

Michael Achenbach

PTAL. I guess this can land before migration day?

6 years, 1 month ago (2014-11-04 13:49:06 UTC) #2

tandrii(chromium)

LGTM for change Not sure about landing now. agable@ ?

6 years, 1 month ago (2014-11-04 14:27:50 UTC) #3

agable

Pending ref prefix can land now; it only affects "git cl land", not "git cl ...

6 years, 1 month ago (2014-11-04 18:07:25 UTC) #4

Michael Achenbach

ok - then I'll land partial tomorrow and make an extra cl for view vc.

6 years, 1 month ago (2014-11-04 20:32:25 UTC) #5

Michael Achenbach

Changed my mind. Lets land the CL as it is on flag day - because ...

6 years, 1 month ago (2014-11-05 08:15:21 UTC) #7

Michael Achenbach

6 years, 1 month ago (2014-11-12 17:42:08 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e7622993c5c27878ffdc6e11a30b8d1f320a4536 (tree was closed).