Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 699113002: Add the check layout framework for tests. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Add the check layout framework for tests. Also add a test for margins. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ffb2a6d6c6b9b329efca23b6d8cabf75464a764e

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove anonymous function #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -0 lines) Patch
A sky/tests/layout/margins.sky View 1 chunk +17 lines, -0 lines 1 comment Download
A sky/tests/layout/margins-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
A sky/tests/resources/check-layout.sky View 1 1 chunk +196 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (1 generated)
ojan
6 years, 1 month ago (2014-11-04 03:22:58 UTC) #2
abarth-chromium
https://codereview.chromium.org/699113002/diff/1/sky/tests/resources/check-layout.sky File sky/tests/resources/check-layout.sky (right): https://codereview.chromium.org/699113002/diff/1/sky/tests/resources/check-layout.sky#newcode2 sky/tests/resources/check-layout.sky:2: (function() { No need for this. All script tags ...
6 years, 1 month ago (2014-11-04 03:42:11 UTC) #3
ojan
https://codereview.chromium.org/699113002/diff/1/sky/tests/resources/check-layout.sky File sky/tests/resources/check-layout.sky (right): https://codereview.chromium.org/699113002/diff/1/sky/tests/resources/check-layout.sky#newcode2 sky/tests/resources/check-layout.sky:2: (function() { On 2014/11/04 03:42:11, abarth wrote: > No ...
6 years, 1 month ago (2014-11-04 04:02:46 UTC) #4
abarth-chromium
LGTM https://codereview.chromium.org/699113002/diff/20001/sky/tests/layout/margins.sky File sky/tests/layout/margins.sky (right): https://codereview.chromium.org/699113002/diff/20001/sky/tests/layout/margins.sky#newcode15 sky/tests/layout/margins.sky:15: window.checkLayout('.root'); Rather than spamming the global, can you ...
6 years, 1 month ago (2014-11-04 04:32:52 UTC) #5
ojan
6 years, 1 month ago (2014-11-04 04:46:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ffb2a6d6c6b9b329efca23b6d8cabf75464a764e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698