Issue 699083005: Specs: define registerElement() a little differently, so that the code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 699083005: Specs: define registerElement() a little differently, so that the code (Closed)

Created:
6 years, 1 month ago by Hixie

Modified:
6 years, 1 month ago

Reviewers:

CC:
mojo-reviews_chromium.org, ojan, esprehn, abarth-chromium

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Specs: define registerElement() a little differently, so that the code that uses it looks nicer; this moves the complexity to places that register elements without using 'class' (e.g. the internals of frameworks that create elements for defining elements) Committed: https://chromium.googlesource.com/external/mojo/+/8d26db77827610c2d1c0fa1ad227c63b1d23d38e

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -20 lines)			Patch
	M	sky/examples/radio.sky	View		4 chunks	+5 lines, -5 lines	0 comments	Download
	M	sky/specs/apis.md	View		4 chunks	+16 lines, -15 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Hixie

6 years, 1 month ago (2014-11-04 20:16:52 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8d26db77827610c2d1c0fa1ad227c63b1d23d38e.

Expand Messages | Collapse Messages