Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 699083003: [turbofan] extend register allocator testing with control flow (Closed)

Created:
6 years, 1 month ago by dcarney
Modified:
6 years, 1 month ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] extend register allocator testing with control flow R=bmeurer@chromium.org, jarin@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=25178

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : repro #

Patch Set 6 : #

Patch Set 7 : fixed repro #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : added js regression test #

Patch Set 11 : rebase #

Patch Set 12 : #

Patch Set 13 : #

Patch Set 14 : fix #

Patch Set 15 : #

Patch Set 16 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+399 lines, -125 lines) Patch
M src/compiler/instruction.h View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +13 lines, -8 lines 0 comments Download
M src/compiler/instruction.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +50 lines, -40 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-instruction.cc View 1 2 3 4 5 6 7 8 9 10 4 chunks +16 lines, -16 lines 0 comments Download
M test/unittests/compiler/register-allocator-unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 5 chunks +318 lines, -59 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Benedikt Meurer
LGTM
6 years, 1 month ago (2014-11-06 08:26:08 UTC) #3
dcarney
6 years, 1 month ago (2014-11-06 08:28:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #16 (id:290001) manually as 25178 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698