Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 699083002: Add hw_video_decode_mac flag for Flash 15.0.0.223. (Closed)

Created:
6 years, 1 month ago by ilja
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add hw_video_decode_mac flag for Flash 15.0.0.223. After 15.0.0.223 Flash version Adobe will use enable_hw_video_decode like on all other platforms. For a short period of time use both flags. BUG=335836 TEST=None. Committed: https://crrev.com/722d18237a29c2f75fbfcccbe8c7afb35179628b Cr-Commit-Position: refs/heads/master@{#303600}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/browser/ppapi_plugin_process_host.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
ilja
6 years, 1 month ago (2014-11-04 00:50:32 UTC) #2
sandersd (OOO until July 31)
lgtm I'm not actually sure what the initial value for this flag should be yet, ...
6 years, 1 month ago (2014-11-04 18:21:09 UTC) #3
ilja
All platforms use enable_hw_video_decode. This was changed for mac to enable_hw_video_decode_mac, but reverted after 15.0.0.223. ...
6 years, 1 month ago (2014-11-04 19:47:18 UTC) #4
ilja
sievers: could you please do an OWNERS review?
6 years, 1 month ago (2014-11-04 19:49:58 UTC) #6
no sievers
On 2014/11/04 19:49:58, ilja wrote: > sievers: could you please do an OWNERS review? lgtm
6 years, 1 month ago (2014-11-04 21:54:23 UTC) #7
ilja
sandersd: I plan to land this after the branching point, as you mentioned before that ...
6 years, 1 month ago (2014-11-04 23:35:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/699083002/1
6 years, 1 month ago (2014-11-11 06:49:25 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-11 07:42:50 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 07:43:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/722d18237a29c2f75fbfcccbe8c7afb35179628b
Cr-Commit-Position: refs/heads/master@{#303600}

Powered by Google App Engine
This is Rietveld 408576698