content: Add command line flag for native GPU memory buffers.

content/common/gpu/client/gpu_memory_buffer_impl_android.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/client/gpu_memory_buffer_impl.h"
 
 #include "base/logging.h"
 #include "content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h"
 #include "content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.h"
 
 namespace content {
 
 // static
 void GpuMemoryBufferImpl::GetSupportedTypes(
     std::vector<gfx::GpuMemoryBufferType>* types) {
   const gfx::GpuMemoryBufferType supported_types[] = {
-    gfx::SURFACE_TEXTURE_BUFFER,
-    gfx::SHARED_MEMORY_BUFFER
+    gfx::SHARED_MEMORY_BUFFER,
+    gfx::SURFACE_TEXTURE_BUFFER

[piman, 2014/11/19 02:39:40]

I would prefer having the decision about the types of buffers that are allowed
to be in a single place.

Really, there's only 2 cases:
1- shm only
2- a single platform-specific type, with a fallback to shm

Which really simplifies to whether or not the platform-specific type (if any) is
allowed.

Maybe it's not worth it to have a list of supported types... We only ever pick
the first element, which may be overridden anyway (from the command line).

I think it would be simpler to have a gfx::GpuMemoryBufferType
GpuMemoryBufferImpl::GetPreferredType() on each platform, which returns a single
type (e.g. EMPTY_BUFFER if none), that may be controlled with the command-line
(on mac and android for a staged rollout).

Then no need for the lazy-initialization logic, or generic override logic.

[reveman, 2014/11/20 00:53:02]

I think my other refactor will result in what you're asking for here. Please
review that patch first and I'll rebase this onto that.

   };
   types->assign(supported_types, supported_types + arraysize(supported_types));
 }
 
 // static
 bool GpuMemoryBufferImpl::IsConfigurationSupported(
     gfx::GpuMemoryBufferType type,
     Format format,
     Usage usage) {
   switch (type) {
@@ skipping 89 matching lines @@
     case gfx::SURFACE_TEXTURE_BUFFER:
       return GpuMemoryBufferImplSurfaceTexture::CreateFromHandle(
           handle, size, format, callback);
     default:
       NOTREACHED();
       return scoped_ptr<GpuMemoryBufferImpl>();
   }
 }
 
 }  // namespace content