Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 699053004: Revert of Fix RemoteFrame detachment to signal its client. (Closed)

Created:
6 years, 1 month ago by raymes
Modified:
6 years, 1 month ago
Reviewers:
kenrb, Nate Chapin, dcheng
CC:
blink-reviews, dglazkov+blink, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Fix RemoteFrame detachment to signal its client. (patchset #1 id:1 of https://codereview.chromium.org/712653002/) Reason for revert: Speculative revert to attempt to fix https://code.google.com/p/chromium/issues/detail?id=431608 Original issue's description: > Fix RemoteFrame detachment to signal its client. > > We were seeing crashes in checkFrameCountConsistency() because during > RemoteFrame detachment the client was not getting signalled to modify > the frame tree, resulting in inconsistent state. This CL corrects that > problem. > > BUG=430972 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184987 TBR=japhet@chromium.org,dcheng@chromium.org,kenrb@chromium.org NOTREECHECKS=true NOTRY=true BUG=430972 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185015

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M Source/web/RemoteFrameClientImpl.cpp View 2 chunks +1 line, -12 lines 0 comments Download
M public/web/WebRemoteFrameClient.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
raymes
Created Revert of Fix RemoteFrame detachment to signal its client.
6 years, 1 month ago (2014-11-10 01:16:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/699053004/1
6 years, 1 month ago (2014-11-10 01:16:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 185015
6 years, 1 month ago (2014-11-10 01:17:03 UTC) #3
raymes
6 years, 1 month ago (2014-11-10 03:05:53 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/709363002/ by raymes@chromium.org.

The reason for reverting is: Reverting the revert. This turned out not to be the
cause of https://code.google.com/p/chromium/issues/detail?id=431608.

Powered by Google App Engine
This is Rietveld 408576698