Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issue 699053003: cc: Ensure that raster contents scale doesn't go below min scale. (Closed)

Created:
6 years, 1 month ago by vmpstr
Modified:
6 years, 1 month ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Ensure that raster contents scale doesn't go below min scale. This patch ensures that we can the raster scale to min contents scale. We already did this, but later could modify the value again to be lower than MinContentsScale. Now, the clamp happens near the end of the function. R=danakj BUG=429397 Committed: https://crrev.com/2eb362d23158c4897a9346edae4e630c6c9f2702 Cr-Commit-Position: refs/heads/master@{#302636}

Patch Set 1 #

Total comments: 3

Patch Set 2 : dcheck #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M cc/layers/picture_layer_impl.cc View 1 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
vmpstr
PTAL
6 years, 1 month ago (2014-11-04 00:36:59 UTC) #1
danakj
https://codereview.chromium.org/699053003/diff/1/cc/layers/picture_layer_impl.cc File cc/layers/picture_layer_impl.cc (right): https://codereview.chromium.org/699053003/diff/1/cc/layers/picture_layer_impl.cc#newcode1141 cc/layers/picture_layer_impl.cc:1141: DCHECK_LE(low_res_raster_contents_scale_, raster_contents_scale_); can you DCHECK GE MinContentsScale() for both ...
6 years, 1 month ago (2014-11-04 16:45:02 UTC) #2
danakj
https://codereview.chromium.org/699053003/diff/1/cc/layers/picture_layer_impl.cc File cc/layers/picture_layer_impl.cc (right): https://codereview.chromium.org/699053003/diff/1/cc/layers/picture_layer_impl.cc#newcode1141 cc/layers/picture_layer_impl.cc:1141: DCHECK_LE(low_res_raster_contents_scale_, raster_contents_scale_); On 2014/11/04 16:45:01, danakj wrote: > can ...
6 years, 1 month ago (2014-11-04 16:45:25 UTC) #3
vmpstr
PTAL https://codereview.chromium.org/699053003/diff/1/cc/layers/picture_layer_impl.cc File cc/layers/picture_layer_impl.cc (right): https://codereview.chromium.org/699053003/diff/1/cc/layers/picture_layer_impl.cc#newcode1141 cc/layers/picture_layer_impl.cc:1141: DCHECK_LE(low_res_raster_contents_scale_, raster_contents_scale_); On 2014/11/04 16:45:25, danakj wrote: > ...
6 years, 1 month ago (2014-11-04 17:24:02 UTC) #4
danakj
LGTM
6 years, 1 month ago (2014-11-04 17:34:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/699053003/20001
6 years, 1 month ago (2014-11-04 17:35:43 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-04 19:04:21 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 19:04:58 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2eb362d23158c4897a9346edae4e630c6c9f2702
Cr-Commit-Position: refs/heads/master@{#302636}

Powered by Google App Engine
This is Rietveld 408576698