Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 699033002: Sync: Handle duplicating tab IDs in foreign session data (Closed)

Created:
6 years, 1 month ago by stanisc
Modified:
6 years, 1 month ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Sync: Handle duplicating tab IDs in foreign session data. This change prevents overwriting a foreign session SessionTab with a data from another node if the SessionTab we already have has a newer timestamp. This ensures that if there are multiple tabs with the same ID, the tab that we end up associating with a window is the most recent one. BUG=423501 Committed: https://crrev.com/dab87227950f67f4bd03276cbe84fa914ae846a3 Cr-Commit-Position: refs/heads/master@{#302674}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -0 lines) Patch
M chrome/browser/sync/sessions/sessions_sync_manager.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc View 1 chunk +77 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
stanisc
Please review this fix.
6 years, 1 month ago (2014-11-04 00:16:31 UTC) #2
Nicolas Zea
LGTM, nice job!
6 years, 1 month ago (2014-11-04 18:56:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/699033002/1
6 years, 1 month ago (2014-11-04 20:41:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-04 21:27:09 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 21:27:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dab87227950f67f4bd03276cbe84fa914ae846a3
Cr-Commit-Position: refs/heads/master@{#302674}

Powered by Google App Engine
This is Rietveld 408576698