chrome/browser/ui/cocoa/tabs/tab_controller.mm - Issue 699013002: [Cocoa] Crash fix, caused by recent tab indicator change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tabs/tab_controller.mm

Issue 699013002: [Cocoa] Crash fix, caused by recent tab indicator change. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/tabs/tab_controller.mm

diff --git a/chrome/browser/ui/cocoa/tabs/tab_controller.mm b/chrome/browser/ui/cocoa/tabs/tab_controller.mm

index 08428b141c70620b975ee43b52b1873d4c4ef5a0..e994ad3d95fb05e9035ad3d40291d2fda199dae9 100644

--- a/chrome/browser/ui/cocoa/tabs/tab_controller.mm

+++ b/chrome/browser/ui/cocoa/tabs/tab_controller.mm

@@ -128,6 +128,10 @@ class MenuDelegate : public ui::SimpleMenuModel::Delegate {

}

- (void)dealloc {

+ if (mediaIndicatorButton_) {

Nico 2014/11/04 00:01:22 (nit: not needed, messages to nil are silently ign

miu 2014/11/04 00:22:29 Done.

+ [mediaIndicatorButton_ setAnimationDoneTarget:nil withAction:nil];

+ [mediaIndicatorButton_ setClickTarget:nil withAction:nil];

+ }

[[NSNotificationCenter defaultCenter] removeObserver:self];

[[self tabView] setController:nil];

[super dealloc];

« no previous file with comments | « no previous file | no next file » | no next file with comments »