Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 699001: Move wtl from chrome/third_party to third_party/. This... (Closed)

Created:
10 years, 9 months ago by tony
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, brettw+cc_chromium.org, dpranke+watch_chromium.org, Alpha Left Google, amit, ben+cc_chromium.org, fbarchard, pam+watch_chromium.org, awong, Paweł Hajdan Jr., darin-cc_chromium.org, scherkus (not reviewing)
Visibility:
Public.

Description

Move wtl from chrome/third_party to third_party/. This breaks dependencies on chrome from webkit, app, views and base. BUG=37649 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41001

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -55996 lines) Patch
M app/app_base.gypi View 1 chunk +1 line, -1 line 0 comments Download
M base/base.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_dll.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 9 chunks +9 lines, -9 lines 0 comments Download
M chrome/nacl.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/interactive_ui/interactive_ui_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
D chrome/third_party/wtl/Ms-PL.txt View 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/third_party/wtl/README.chromium View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/third_party/wtl/include/atlapp.h View 1 chunk +0 lines, -1685 lines 0 comments Download
D chrome/third_party/wtl/include/atlcrack.h View 1 chunk +0 lines, -2377 lines 0 comments Download
D chrome/third_party/wtl/include/atlctrls.h View 1 chunk +0 lines, -10036 lines 0 comments Download
D chrome/third_party/wtl/include/atlctrlw.h View 1 chunk +0 lines, -4158 lines 0 comments Download
D chrome/third_party/wtl/include/atlctrlx.h View 1 chunk +0 lines, -4824 lines 0 comments Download
D chrome/third_party/wtl/include/atlddx.h View 1 chunk +0 lines, -621 lines 0 comments Download
D chrome/third_party/wtl/include/atldlgs.h View 1 chunk +0 lines, -6209 lines 0 comments Download
D chrome/third_party/wtl/include/atlfind.h View 1 chunk +0 lines, -1033 lines 0 comments Download
D chrome/third_party/wtl/include/atlframe.h View 1 chunk +0 lines, -3462 lines 0 comments Download
D chrome/third_party/wtl/include/atlgdi.h View 1 chunk +0 lines, -3847 lines 0 comments Download
D chrome/third_party/wtl/include/atlmisc.h View 1 chunk +0 lines, -4018 lines 0 comments Download
D chrome/third_party/wtl/include/atlprint.h View 1 chunk +0 lines, -1110 lines 0 comments Download
D chrome/third_party/wtl/include/atlres.h View 1 chunk +0 lines, -259 lines 0 comments Download
D chrome/third_party/wtl/include/atlresce.h View 1 chunk +0 lines, -90 lines 0 comments Download
D chrome/third_party/wtl/include/atlscrl.h View 1 chunk +0 lines, -2012 lines 0 comments Download
D chrome/third_party/wtl/include/atlsplit.h View 1 chunk +0 lines, -889 lines 0 comments Download
D chrome/third_party/wtl/include/atltheme.h View 1 chunk +0 lines, -1215 lines 0 comments Download
D chrome/third_party/wtl/include/atluser.h View 1 chunk +0 lines, -1159 lines 0 comments Download
chrome/third_party/wtl/include/atlwince.h View 1 chunk +0 lines, -3007 lines 0 comments Download
D chrome/third_party/wtl/include/atlwinx.h View 1 chunk +0 lines, -526 lines 0 comments Download
D chrome/third_party/wtl/readme.htm View 1 chunk +0 lines, -3336 lines 0 comments Download
D chrome/third_party/wtl/using_wtl.vsprops View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome_frame/chrome_frame.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M media/media.gyp View 1 chunk +1 line, -1 line 0 comments Download
M media/tools/player_wtl/player_wtl.rc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/memory_watcher/memory_watcher.gyp View 1 chunk +1 line, -2 lines 0 comments Download
views/views.gyp View 3 chunks +3 lines, -4 lines 0 comments Download
M webkit/default_plugin/default_plugin.gyp View 1 chunk +1 line, -1 line 0 comments Download
webkit/tools/test_shell/test_shell.gypi View 1 chunk +1 line, -1 line 0 comments Download
M webkit/webkit.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tony
I don't know why the A+ third_party/wtl isn't showing up. It shows up in my ...
10 years, 9 months ago (2010-03-09 03:37:19 UTC) #1
M-A Ruel
On 2010/03/09 03:37:19, tony wrote: > I don't know why the A+ third_party/wtl isn't showing ...
10 years, 9 months ago (2010-03-09 03:48:20 UTC) #2
tony
On 2010/03/09 03:48:20, Marc-Antoine Ruel wrote: > On 2010/03/09 03:37:19, tony wrote: > > I ...
10 years, 9 months ago (2010-03-09 03:52:32 UTC) #3
M-A Ruel
On 2010/03/09 03:52:32, tony wrote: > On 2010/03/09 03:48:20, Marc-Antoine Ruel wrote: > > On ...
10 years, 9 months ago (2010-03-09 04:04:49 UTC) #4
tony
10 years, 9 months ago (2010-03-09 05:07:16 UTC) #5
Compile passed here the try bot, so I'm going to commit.
http://build.chromium.org/buildbot/try-server/builders/win/builds/21939

Powered by Google App Engine
This is Rietveld 408576698