Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Issue 698993002: [Mac] Don't pre-emptively update the profile name in the avatar bubble after an update. (Closed)

Created:
6 years, 1 month ago by noms (inactive)
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Mac] Don't pre-emptively update the profile name in the avatar bubble after an update. If the user entered name is accepted and saved, then the entire view is refreshed and the new name is displayed. Automatically committing the name is too eager, since UpdateProfileName might reject the name in some cases (if it's identical to the original one), and we might ignore the display rules around single profiles and "You". BUG=428683 TEST=Start Chrome with --enable-new-avatar-menu. Make sure you only have one, brand new profile. Open chrome://settings and in the avatar bubble (which should display "You") enter the same name that the profile has in chrome://settings (like Person 1). The name displayed in the bubble should stay as "You" Committed: https://crrev.com/b9ebd3861a8c8aad6e91c8fd43f32d917d2e380e Cr-Commit-Position: refs/heads/master@{#302509}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
noms (inactive)
6 years, 1 month ago (2014-11-03 21:08:22 UTC) #2
Alexei Svitkine (slow)
lgtm
6 years, 1 month ago (2014-11-03 22:08:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/698993002/1
6 years, 1 month ago (2014-11-03 22:10:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-03 22:56:54 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 22:57:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9ebd3861a8c8aad6e91c8fd43f32d917d2e380e
Cr-Commit-Position: refs/heads/master@{#302509}

Powered by Google App Engine
This is Rietveld 408576698