Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 698963002: [turbofan] Strip useless sign-extension for store8/store16. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer
Modified:
6 years, 1 month ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Strip useless sign-extension for store8/store16. TEST=unittests R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25091

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -16 lines) Patch
M src/compiler/machine-operator-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 2 chunks +37 lines, -16 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 2 chunks +48 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Benedikt Meurer
PTAL
6 years, 1 month ago (2014-11-04 06:53:00 UTC) #2
Sven Panne
lgtm
6 years, 1 month ago (2014-11-04 07:34:40 UTC) #3
Benedikt Meurer
6 years, 1 month ago (2014-11-04 07:35:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 25091 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698