Issue 698943002: patch from issue 697743002

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 698943002: patch from issue 697743002 (Closed)

Created:
6 years, 1 month ago by mtklein_C

Modified:
6 years, 1 month ago

Reviewers:
jcgregorio, stephana, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

patch from issue 697743002 working The key here was to get everything into a single library. Our shared library build is the easiest way to do that. Some light skimming online makes it look like perhaps cgo requires shared libraries, so that may be at play here too. BUG=skia: Committed: https://skia.googlesource.com/skia/+/3eeb156822d5062aaa8909d6bc53c734c94fb8f2

Patch Set 1 #

Patch Set 2 : build instructions #

Patch Set 3 : comment #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -19 lines)			Patch
	M	experimental/go-skia/skia.go	View	1 2	1 chunk	+27 lines, -19 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/698943002/40001

6 years, 1 month ago (2014-11-03 18:37:38 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-11-03 18:45:54 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as 3eeb156822d5062aaa8909d6bc53c734c94fb8f2

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages