Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: Source/bindings/core/v8/custom/V8DocumentCustom.cpp

Issue 698923002: Enable Oilpan for core/xml/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Non-Oilpan fixes Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/custom/V8CustomXPathNSResolver.cpp ('k') | Source/bindings/scripts/v8_types.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/custom/V8DocumentCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8DocumentCustom.cpp b/Source/bindings/core/v8/custom/V8DocumentCustom.cpp
index 82f47066f6fcf466c7fce43dd7f240606f898b3d..38b3fe681dbf7a4714fa6a02b49f44f8a9083959 100644
--- a/Source/bindings/core/v8/custom/V8DocumentCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8DocumentCustom.cpp
@@ -67,7 +67,7 @@ void V8Document::evaluateMethodCustom(const v8::FunctionCallbackInfo<v8::Value>&
RefPtrWillBeRawPtr<Node> contextNode = V8Node::toImplWithTypeCheck(info.GetIsolate(), info[1]);
const int resolverArgumentIndex = 2;
- RefPtrWillBeRawPtr<XPathNSResolver> resolver = toXPathNSResolver(info.GetIsolate(), info[resolverArgumentIndex]);
+ XPathNSResolver* resolver = toXPathNSResolver(info.GetIsolate(), info[resolverArgumentIndex]);
if (!resolver && !isUndefinedOrNull(info[resolverArgumentIndex])) {
exceptionState.throwTypeError(ExceptionMessages::argumentNullOrIncorrectType(resolverArgumentIndex + 1, "XPathNSResolver"));
exceptionState.throwIfNeeded();
@@ -75,12 +75,12 @@ void V8Document::evaluateMethodCustom(const v8::FunctionCallbackInfo<v8::Value>&
}
int type = toInt32(info[3]);
- RefPtrWillBeRawPtr<XPathResult> inResult = V8XPathResult::toImplWithTypeCheck(info.GetIsolate(), info[4]);
- TONATIVE_VOID(RefPtrWillBeRawPtr<XPathResult>, result, DocumentXPathEvaluator::evaluate(*document, expression, contextNode.get(), resolver.release(), type, inResult.get(), exceptionState));
+ XPathResult* inResult = V8XPathResult::toImplWithTypeCheck(info.GetIsolate(), info[4]);
+ TONATIVE_VOID(XPathResult*, result, DocumentXPathEvaluator::evaluate(*document, expression, contextNode.get(), resolver, type, inResult, exceptionState));
if (exceptionState.throwIfNeeded())
return;
- v8SetReturnValueFast(info, result.release(), document.get());
+ v8SetReturnValueFast(info, result, document.get());
}
} // namespace blink
« no previous file with comments | « Source/bindings/core/v8/custom/V8CustomXPathNSResolver.cpp ('k') | Source/bindings/scripts/v8_types.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698