Source/bindings/core/v8/V8Binding.cpp - Issue 698923002: Enable Oilpan for core/xml/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8Binding.cpp

Issue 698923002: Enable Oilpan for core/xml/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Non-Oilpan fixes Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/V8Binding.cpp

diff --git a/Source/bindings/core/v8/V8Binding.cpp b/Source/bindings/core/v8/V8Binding.cpp

index 6eacca6d18be06da4bce891f7bbd6cf6ebb3b497..44a384f92639a2c262e17877ab9aaff40a7899f2 100644

--- a/Source/bindings/core/v8/V8Binding.cpp

+++ b/Source/bindings/core/v8/V8Binding.cpp

@@ -685,9 +685,9 @@ String toUSVString(v8::Handle<v8::Value> value, ExceptionState& exceptionState)

return replaceUnmatchedSurrogates(x);

}

-PassRefPtrWillBeRawPtr<XPathNSResolver> toXPathNSResolver(v8::Isolate* isolate, v8::Handle<v8::Value> value)

+XPathNSResolver* toXPathNSResolver(v8::Isolate* isolate, v8::Handle<v8::Value> value)

{

- RefPtrWillBeRawPtr<XPathNSResolver> resolver = nullptr;

+ XPathNSResolver* resolver = nullptr;

if (V8XPathNSResolver::hasInstance(value, isolate))

resolver = V8XPathNSResolver::toImpl(v8::Handle<v8::Object>::Cast(value));

else if (value->IsObject())