Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 698883005: Update mojo sdk to rev cfc99316100efdfa7d53d83f9e07f1d4d3765c21 (Closed)

Created:
6 years, 1 month ago by jamesr
Modified:
6 years, 1 month ago
Reviewers:
jam, viettrungluu
CC:
chromium-reviews, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, dcheng, piman+watch_chromium.org, chromium-apps-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update mojo sdk to rev cfc99316100efdfa7d53d83f9e07f1d4d3765c21 Most changes are updates to the mojom syntax for modules. R=viettrungluu@chromium.org TBR=jam@chromium.org Committed: https://crrev.com/0f18be91be7c4aa9e55ad020fa5a2408f389a9d1 Cr-Commit-Position: refs/heads/master@{#302542}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -536 lines) Patch
M content/common/geolocation_service.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M content/common/render_frame_setup.mojom View 1 chunk +2 lines, -4 lines 0 comments Download
M content/public/common/mojo_geoposition.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M content/test/data/web_ui_test_mojo_bindings.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M device/battery/battery_monitor.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M device/battery/battery_status.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M device/serial/data_stream.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M device/serial/data_stream_serialization.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M device/serial/serial.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M device/serial/serial_serialization.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M extensions/common/mojo/keep_alive.mojom View 1 chunk +1 line, -3 lines 0 comments Download
M extensions/common/mojo/stash.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M ipc/mojo/client_channel.mojom View 1 chunk +1 line, -3 lines 0 comments Download
M media/mojo/interfaces/demuxer_stream.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M media/mojo/interfaces/media_renderer.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M media/mojo/interfaces/media_types.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/application_manager/test.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/public/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/VERSION View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/c/system/tests/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/public/cpp/application/BUILD.gn View 2 chunks +14 lines, -4 lines 0 comments Download
M mojo/public/cpp/application/application_delegate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/public/cpp/application/lib/application_test_main.cc View 1 chunk +1 line, -0 lines 0 comments Download
D mojo/public/html/BUILD.gn View 1 chunk +0 lines, -25 lines 0 comments Download
D mojo/public/html/convert_amd_modules_to_html.py View 1 chunk +0 lines, -99 lines 0 comments Download
M mojo/public/interfaces/application/application.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/public/interfaces/application/service_provider.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/public/interfaces/application/shell.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/math_calculator.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/rect.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/regression_tests.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_factory.mojom View 2 chunks +3 lines, -5 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_import.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_import2.mojom View 2 chunks +3 lines, -5 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_interfaces.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_service.mojom View 2 chunks +3 lines, -5 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/serialization_test_structs.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/test_structs.mojom View 2 chunks +3 lines, -5 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom View 2 chunks +1 line, -3 lines 0 comments Download
A + mojo/public/sky/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/public/sky/convert_amd_modules_to_sky.py View 2 chunks +3 lines, -3 lines 0 comments Download
D mojo/public/tools/bindings/generators/js_templates/module.html.tmpl View 1 chunk +0 lines, -13 lines 0 comments Download
A + mojo/public/tools/bindings/generators/js_templates/module.sky.tmpl View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_js_generator.py View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom_bindings_generator.gypi View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/parse/ast.py View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/parse/parser.py View 2 chunks +29 lines, -23 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom_tests/parse/parser_unittest.py View 22 chunks +93 lines, -48 lines 0 comments Download
M mojo/public/tools/download_shell_binary.py View 2 chunks +39 lines, -27 lines 0 comments Download
M mojo/services/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/public/cpp/geometry/geometry_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.h View 5 chunks +6 lines, -6 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_test_suite.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M mojo/services/public/interfaces/clipboard/clipboard.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/services/public/interfaces/content_handler/content_handler.mojom View 1 chunk +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/geometry/geometry.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/services/public/interfaces/gpu/command_buffer.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/services/public/interfaces/gpu/gpu.mojom View 1 chunk +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/input_events/input_event_constants.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/services/public/interfaces/input_events/input_events.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/input_events/input_key_codes.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/services/public/interfaces/native_viewport/native_viewport.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/navigation/navigation.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/network/cookie_store.mojom View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/services/public/interfaces/network/net_address.mojom View 2 chunks +1 line, -4 lines 0 comments Download
M mojo/services/public/interfaces/network/network_error.mojom View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/services/public/interfaces/network/network_service.mojom View 3 chunks +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/network/tcp_bound_socket.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/network/tcp_connected_socket.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/services/public/interfaces/network/tcp_server_socket.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/network/udp_socket.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/network/url_loader.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/network/web_socket.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/surfaces/quads.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/surfaces/surface_id.mojom View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/services/public/interfaces/surfaces/surfaces.mojom View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/surfaces/surfaces_service.mojom View 1 chunk +2 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 3 chunks +6 lines, -6 lines 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager_constants.mojom View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/services/public/interfaces/window_manager/window_manager.mojom View 1 chunk +12 lines, -3 lines 0 comments Download
M mojo/services/public/interfaces/window_manager/window_manager_internal.mojom View 2 chunks +15 lines, -5 lines 0 comments Download
D mojo/services/public/interfaces/window_manager2/BUILD.gn View 1 chunk +0 lines, -12 lines 0 comments Download
M mojo/services/public/interfaces/window_manager2/window_manager2.mojom View 2 chunks +1 line, -3 lines 0 comments Download
M mojo/services/public/mojo_services_public.gyp View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jamesr
viettrungluu@ - for review, since this is mostly mojom syntax changes jam@ - for top-level ...
6 years, 1 month ago (2014-11-04 00:03:46 UTC) #2
viettrungluu
lgtm
6 years, 1 month ago (2014-11-04 00:48:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/698883005/1
6 years, 1 month ago (2014-11-04 00:51:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-04 01:46:19 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 01:46:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f18be91be7c4aa9e55ad020fa5a2408f389a9d1
Cr-Commit-Position: refs/heads/master@{#302542}

Powered by Google App Engine
This is Rietveld 408576698