Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 698853003: Port get_gn_arg_value() to native Python code so that it works on Windows. (Closed)

Created:
6 years, 1 month ago by jam
Modified:
6 years, 1 month ago
Reviewers:
sky
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Port get_gn_arg_value() to native Python code so that it works on Windows. This allows Goma to work on Win builder. R=sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a46d0125c9a52f23a17939fc48a93e2563db74cd

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M mojo/tools/mojob.py View 1 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jam
6 years, 1 month ago (2014-11-10 20:33:19 UTC) #2
sky
LGTM https://codereview.chromium.org/698853003/diff/1/mojo/tools/mojob.py File mojo/tools/mojob.py (right): https://codereview.chromium.org/698853003/diff/1/mojo/tools/mojob.py#newcode76 mojo/tools/mojob.py:76: with open (os.path.join(out_dir, "args.gn"), "r") as args_file: Do ...
6 years, 1 month ago (2014-11-10 20:50:46 UTC) #3
jam
https://codereview.chromium.org/698853003/diff/1/mojo/tools/mojob.py File mojo/tools/mojob.py (right): https://codereview.chromium.org/698853003/diff/1/mojo/tools/mojob.py#newcode76 mojo/tools/mojob.py:76: with open (os.path.join(out_dir, "args.gn"), "r") as args_file: On 2014/11/10 ...
6 years, 1 month ago (2014-11-10 21:43:22 UTC) #4
jam
6 years, 1 month ago (2014-11-10 21:47:31 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
a46d0125c9a52f23a17939fc48a93e2563db74cd.

Powered by Google App Engine
This is Rietveld 408576698