Issue 69883007: Extract chrome.runtime API code from extensions::EventRouter

Issue 69883007: Extract chrome.runtime API code from extensions::EventRouter (Closed)

Created:
7 years, 1 month ago by James Cook

Modified:
7 years, 1 month ago

Reviewers:
Yoyo Zhou, DaveMoore

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Extract chrome.runtime API code from extensions::EventRouter This is part of the AppShell extensions refactor project. BUG=316367 TEST=unit_tests, browser_tests TBR=dmazzoni@chromium.org for trivial fix to tts_extension_loader_chromeos.h Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235646

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : cleanup #

Patch Set 4 : rebase #

Patch Set 5 : fix chromeos #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+215 lines, -92 lines)			Patch
M	chrome/browser/extensions/api/runtime/runtime_api.h	View		2 chunks	+31 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/runtime/runtime_api.cc	View	1	4 chunks	+92 lines, -0 lines	0 comments	Download
A +	chrome/browser/extensions/api/runtime/runtime_api_factory.h	View	1 2 3	1 chunk	+16 lines, -11 lines	0 comments	Download
A	chrome/browser/extensions/api/runtime/runtime_api_factory.cc	View		1 chunk	+55 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/chrome_extensions_browser_client.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/chrome_extensions_browser_client.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/event_router.h	View	1 2	7 chunks	+6 lines, -11 lines	0 comments	Download
M	chrome/browser/extensions/event_router.cc	View	1 2 3	6 chunks	+1 line, -63 lines	0 comments	Download
M	chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/speech/tts_extension_loader_chromeos.h	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	extensions/browser/extensions_browser_client.h	View		2 chunks	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

James Cook

yoz, PTAL https://codereview.chromium.org/69883007/diff/10012/chrome/browser/extensions/api/runtime/runtime_api.h File chrome/browser/extensions/api/runtime/runtime_api.h (right): https://codereview.chromium.org/69883007/diff/10012/chrome/browser/extensions/api/runtime/runtime_api.h#newcode33 chrome/browser/extensions/api/runtime/runtime_api.h:33: class RuntimeAPI : public BrowserContextKeyedService, I decided ...

7 years, 1 month ago (2013-11-14 01:34:01 UTC) #1

James Cook

Dave, can I get OWNERS for c/b/profiles/chrome_browser_main_extra_parts_profiles.cc?

7 years, 1 month ago (2013-11-15 17:23:00 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/69883007/260001

7 years, 1 month ago (2013-11-15 22:56:28 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/69883007/260001

7 years, 1 month ago (2013-11-16 00:50:49 UTC) #6

Message was sent while issue was closed.

Change committed as 235646

Expand Messages | Collapse Messages