Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 698803002: Use WeakPtr for RTCPeerConnectionHandler and RTCPeerConnectionTracker. (Closed)

Created:
6 years, 1 month ago by tommi (sloooow) - chröme
Modified:
6 years, 1 month ago
Reviewers:
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use WeakPtr for RTCPeerConnectionHandler and RTCPeerConnectionTracker. These objects don't have the same lifetime and we were using raw pointers to them in a few places, which could lead to use-after-free. BUG=429477 TBR=perkj@chromium.org NOTRY=true Committed: https://crrev.com/2c0f13b39d6ff1a867385e1acb7e6793a0440519 Cr-Commit-Position: refs/heads/master@{#302398}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -39 lines) Patch
M content/renderer/media/peer_connection_tracker.h View 2 chunks +4 lines, -1 line 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.h View 3 chunks +2 lines, -4 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.cc View 12 chunks +36 lines, -32 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
tommi (sloooow) - chröme
6 years, 1 month ago (2014-11-02 08:46:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/698803002/1
6 years, 1 month ago (2014-11-02 08:49:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/698803002/1
6 years, 1 month ago (2014-11-02 10:12:05 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-02 10:12:25 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-02 10:13:04 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c0f13b39d6ff1a867385e1acb7e6793a0440519
Cr-Commit-Position: refs/heads/master@{#302398}

Powered by Google App Engine
This is Rietveld 408576698