Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 698783002: Revert of Revert of Add logs to debug a flakiness on GPU Mac bots. (Closed)

Created:
6 years, 1 month ago by Zhenyao Mo
Modified:
6 years, 1 month ago
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, piman+watch_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Add logs to debug a flakiness on GPU Mac bots. (patchset #1 id:1 of https://codereview.chromium.org/684253003/) Reason for revert: Ah, reverted the wrong CL. Original issue's description: > Revert of Add logs to debug a flakiness on GPU Mac bots. (patchset #2 id:20001 of https://codereview.chromium.org/684423005/) > > Reason for revert: > Should turn on logging in telemetry_gpu_tests in general. > > Original issue's description: > > Add logs to debug a flakiness on GPU Mac bots. > > > > This is temporary and will be removed after we pin down the issue. > > > > BUG=424024 > > TEST= > > R=kbr@chromium.org > > TBR=dgozman@chromium.org > > NOTRY=true > > > > Committed: https://crrev.com/16aa242c3456dc68cd91ef2c683158799c8441b0 > > Cr-Commit-Position: refs/heads/master@{#302371} > > TBR=dgozman@chromium.org,kbr@chromium.org,pfeldman@chromium.org,yurys@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=424024 > > Committed: https://crrev.com/ec506e7f57922e5a068d76128f020877bc7986cb > Cr-Commit-Position: refs/heads/master@{#302387} TBR=dgozman@chromium.org,kbr@chromium.org,pfeldman@chromium.org,yurys@chromium.org NOTREECHECKS=true NOTRY=true BUG=424024 Committed: https://crrev.com/ce1b1bf47b9a1f60d604a5f766a28e4948e598dc Cr-Commit-Position: refs/heads/master@{#302388}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M content/browser/devtools/devtools_http_handler_impl.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/devtools/devtools_system_info_handler.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl_private.cc View 4 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Zhenyao Mo
Created Revert of Revert of Add logs to debug a flakiness on GPU Mac bots.
6 years, 1 month ago (2014-11-01 16:24:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/698783002/1
6 years, 1 month ago (2014-11-01 16:25:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-01 16:25:56 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-11-01 16:26:44 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce1b1bf47b9a1f60d604a5f766a28e4948e598dc
Cr-Commit-Position: refs/heads/master@{#302388}

Powered by Google App Engine
This is Rietveld 408576698