Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 698733002: Mojo/Go build rule changes. (Closed)

Created:
6 years, 1 month ago by gautham
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mojo/Go build rule changes. TBR=darin@chromium.org for trivial third_party/*/BUILD.gn changes Committed: https://crrev.com/8c0287411314d7cbebc15608db1d48e356b79f92 Cr-Commit-Position: refs/heads/master@{#302375}

Patch Set 1 #

Patch Set 2 : Add go build rule for mojo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M build/go/rules.gni View 1 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
gautham
6 years, 1 month ago (2014-11-01 00:25:16 UTC) #2
jamesr
lgtm
6 years, 1 month ago (2014-11-01 00:28:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/698733002/1
6 years, 1 month ago (2014-11-01 00:29:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-01 01:12:04 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-01 01:12:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c0287411314d7cbebc15608db1d48e356b79f92
Cr-Commit-Position: refs/heads/master@{#302375}

Powered by Google App Engine
This is Rietveld 408576698