Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 698703003: Delay a QUIC server's use of the FORWARD_SECURE encrypter until the (Closed)

Created:
6 years, 1 month ago by ramant (doing other things)
Modified:
6 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@Change_QUIC_Reno_congestion_controller_78728349
Project:
chromium
Visibility:
Public.

Description

Delay a QUIC server's use of the FORWARD_SECURE encrypter until the client has had a chance to start using it. Protected by FLAGS_enable_quic_delay_forward_security. When the forward secure encrypter is available, don't use it until one of two things happens: 1) the peers starts sending forward secure encrypted packets 2) 2 round trips worth of packets have been sent, in case something (MitM?) is preventing the peer from using forward secure encryption. Merge internal change: 78801773 R=rch@chromium.org

Patch Set 1 #

Total comments: 2

Patch Set 2 : set FLAGS_enable_quic_delay_forward_security to true #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -5 lines) Patch
M net/quic/quic_connection.h View 2 chunks +8 lines, -1 line 0 comments Download
M net/quic/quic_connection.cc View 4 chunks +30 lines, -0 lines 0 comments Download
M net/quic/quic_connection_test.cc View 1 chunk +57 lines, -0 lines 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M net/quic/quic_flags.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_flags.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ramant (doing other things)
6 years, 1 month ago (2014-11-01 00:25:12 UTC) #1
Ryan Hamilton
lgtm https://codereview.chromium.org/698703003/diff/1/net/quic/quic_flags.cc File net/quic/quic_flags.cc (right): https://codereview.chromium.org/698703003/diff/1/net/quic/quic_flags.cc#newcode64 net/quic/quic_flags.cc:64: bool FLAGS_enable_quic_delay_forward_security = false; I think you can ...
6 years, 1 month ago (2014-11-03 18:09:34 UTC) #2
ramant (doing other things)
6 years, 1 month ago (2014-11-03 18:28:52 UTC) #3
https://codereview.chromium.org/698703003/diff/1/net/quic/quic_flags.cc
File net/quic/quic_flags.cc (right):

https://codereview.chromium.org/698703003/diff/1/net/quic/quic_flags.cc#newco...
net/quic/quic_flags.cc:64: bool FLAGS_enable_quic_delay_forward_security =
false;
On 2014/11/03 18:09:34, Ryan Hamilton wrote:
> I think you can go ahead and set this to true. It shouldn't actually matter
> client-side so it might be worth turning it on to exercise the code path.

Done.

Powered by Google App Engine
This is Rietveld 408576698