Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 6987001: Disable the mutex protecting multiple-lines of log output from being separated. (Closed)

Created:
9 years, 7 months ago by pdox
Modified:
9 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Disable the mutex protecting multiple-lines of log output from being separated. The mutex class requires C++, which makes libsrpc incompatible with plain C. Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=5228

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M src/shared/srpc/utility.c View 1 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pdox
9 years, 7 months ago (2011-05-09 22:20:24 UTC) #1
pdox
PTAL
9 years, 7 months ago (2011-05-09 22:34:38 UTC) #2
jvoung - send to chromium...
LGTM - sehr please confirm
9 years, 7 months ago (2011-05-09 22:37:57 UTC) #3
robertm
It is a little surprising that commenting out what looks like C functions, prevents c++ ...
9 years, 7 months ago (2011-05-09 23:09:46 UTC) #4
sehr (please use chromium)
9 years, 7 months ago (2011-05-10 00:14:43 UTC) #5
Gregoryd added some code long ago from Chrome that uses C++ to implement a C
interface.  David is commenting those out at my suggestion (thanks, David)
while I rewrite the C++ implementation. FWIW, there is similar language
"inversion" in IMC that should be rewritten.

David

On Mon, May 9, 2011 at 4:09 PM, <robertm@google.com> wrote:

> It is a little surprising that commenting out what looks like C functions,
> prevents c++ libraries from being dragged in.
> Could you elaborate a little what is going on underneath so that
> we have a searchable record.
>
>
>
> On 2011/05/09 22:37:57, jvoung wrote:
>
>> LGTM - sehr please confirm
>>
>
>
>
> http://codereview.chromium.org/6987001/
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.

Powered by Google App Engine
This is Rietveld 408576698