Issue 698673002: Add MinidumpExceptionWriter::InitializeFromSnapshot() and test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 698673002: Add MinidumpExceptionWriter::InitializeFromSnapshot() and test (Closed)

Created:
6 years, 1 month ago by Mark Mentovai

Modified:
6 years, 1 month ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@minidump_init_from_snapshot_thread_new

Project:
crashpad

Visibility:
Public.

Add MinidumpExceptionWriter::InitializeFromSnapshot() and test. TEST=minidump_test MinidumpExceptionWriter.InitializeFromSnapshot R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/62b097629059d6e5abcf9087f24720a0c68211a4

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+246 lines, -0 lines)			Patch
M	minidump/minidump_exception_writer.h	View		2 chunks	+17 lines, -0 lines	0 comments	Download
M	minidump/minidump_exception_writer.cc	View		2 chunks	+21 lines, -0 lines	0 comments	Download
M	minidump/minidump_exception_writer_test.cc	View		2 chunks	+59 lines, -0 lines	0 comments	Download
M	snapshot/snapshot.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	snapshot/test/test_exception_snapshot.h	View	1	1 chunk	+88 lines, -0 lines	0 comments	Download
A	snapshot/test/test_exception_snapshot.cc	View	1	1 chunk	+59 lines, -0 lines	0 comments	Download

Total messages: 6 (3 generated)

Mark Mentovai

This depends on https://codereview.chromium.org/693933002/.

6 years, 1 month ago (2014-10-31 19:38:45 UTC) #2

Mark Mentovai

6 years, 1 month ago (2014-11-04 17:41:05 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:80001) manually as
62b097629059d6e5abcf9087f24720a0c68211a4 (presubmit successful).