Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 698653002: Add initial SkyElement & city-list example (Closed)

Created:
6 years, 1 month ago by rafaelw
Modified:
6 years, 1 month ago
Reviewers:
eseidel
CC:
ojan, abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : moar cleanup #

Total comments: 4

Patch Set 4 : even moar #

Patch Set 5 : ok, ready #

Patch Set 6 : ws #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8173 lines, -0 lines) Patch
A sky/examples/city-list/city-data-service.sky View 1 2 3 4 5 1 chunk +5048 lines, -0 lines 0 comments Download
A sky/examples/city-list/city-list.sky View 1 2 3 4 1 chunk +595 lines, -0 lines 0 comments Download
A sky/examples/city-list/city-sequence.sky View 1 1 chunk +64 lines, -0 lines 0 comments Download
A sky/examples/city-list/index.sky View 1 2 3 1 chunk +33 lines, -0 lines 0 comments Download
A sky/framework/sky-element/TemplateBinding.sky View 1 2 3 4 5 1 chunk +1003 lines, -0 lines 0 comments Download
A sky/framework/sky-element/observe.sky View 1 2 3 4 5 1 chunk +1367 lines, -0 lines 0 comments Download
A sky/framework/sky-element/sky-element.sky View 1 2 3 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
eseidel
rs lgtm
6 years, 1 month ago (2014-10-31 19:16:57 UTC) #2
rafaelw
Committed patchset #6 (id:100001) manually as 78ce7dacf51660ab6b6389479daf7d66e18c1d27 (presubmit successful).
6 years, 1 month ago (2014-10-31 19:30:08 UTC) #3
ojan
Just some random questions from skimming this patch. https://codereview.chromium.org/698653002/diff/40001/sky/examples/city-list/city-list.sky File sky/examples/city-list/city-list.sky (right): https://codereview.chromium.org/698653002/diff/40001/sky/examples/city-list/city-list.sky#newcode119 sky/examples/city-list/city-list.sky:119: #scroller::-webkit-scrollbar ...
6 years, 1 month ago (2014-10-31 19:40:21 UTC) #5
rafaelw
6 years, 1 month ago (2014-11-04 19:01:56 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/698653002/diff/40001/sky/examples/city-list/c...
File sky/examples/city-list/city-list.sky (right):

https://codereview.chromium.org/698653002/diff/40001/sky/examples/city-list/c...
sky/examples/city-list/city-list.sky:119: #scroller::-webkit-scrollbar {
Probably not, since it doesn't do anything.

The desired behavior here was to have a truely infinite list, without any
scrollbar.

I'm not sure I feel strongly about styling the built-in scroll bar, but it seems
like we need a way to use the platform's scrolling, but not show a scroll bar.

On 2014/10/31 19:40:21, ojan wrote:
> Is this needed? We've been talking about removing custom scrollbar support.

https://codereview.chromium.org/698653002/diff/40001/sky/examples/city-list/c...
sky/examples/city-list/city-list.sky:249: console.log(ex.stack);
The do not (log uncaught exceptions) to the console in sky -- which is a pretty
big bummer.

On 2014/10/31 19:40:21, ojan wrote:
> Did we fork before promises correctly logged uncaught exceptions to the
console?
> Actually...I'm not even sure they do on tip of tree blink at the moment. This
is
> something we're going to have to fix.

Powered by Google App Engine
This is Rietveld 408576698