chrome/browser/chromeos/login/user_image_loader.cc - Issue 69863006: Address races in UserImageManagerImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/user_image_loader.cc

Issue 69863006: Address races in UserImageManagerImpl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix WallpaperManager browser tests now that UserImageLoader contains a DCHECK(success). Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/login/user_image_loader.cc

diff --git a/chrome/browser/chromeos/login/user_image_loader.cc b/chrome/browser/chromeos/login/user_image_loader.cc

index e12876cd2d686a71e91b831144247085de76a903..bbb7c6b31bfacaf7a1909b2c5b2a285cc528eaf6 100644

--- a/chrome/browser/chromeos/login/user_image_loader.cc

+++ b/chrome/browser/chromeos/login/user_image_loader.cc

@@ -66,7 +66,9 @@ void UserImageLoader::ReadAndDecodeImage(const std::string& filepath,

DCHECK(background_task_runner_->RunsTasksOnCurrentThread());

scoped_ptr<std::string> data(new std::string);

- base::ReadFileToString(base::FilePath(filepath), data.get());

+ const bool success =

+ base::ReadFileToString(base::FilePath(filepath), data.get());

+ DCHECK(success);

DecodeImage(data.Pass(), image_info);

}