chrome/browser/extensions/extension_system_impl.h - Issue 698623002: Split WarningService from ExtensionSystem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_system_impl.h

Issue 698623002: Split WarningService from ExtensionSystem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: virtual -> override Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/browser_context_keyed_service_factories.cc ('k') | chrome/browser/extensions/extension_system_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_system_impl.h

diff --git a/chrome/browser/extensions/extension_system_impl.h b/chrome/browser/extensions/extension_system_impl.h

index 9961fceb5fce12f09394abceb18f00c056077284..27ea9b8d3fa17302eec8284757806172901757c6 100644

--- a/chrome/browser/extensions/extension_system_impl.h

+++ b/chrome/browser/extensions/extension_system_impl.h

@@ -16,7 +16,6 @@ namespace extensions {

class ContentVerifier;

class DeclarativeUserScriptMaster;

class ExtensionSystemSharedFactory;

-class ExtensionWarningBadgeService;

class NavigationObserver;

class SharedUserScriptMaster;

class StateStoreNotificationObserver;

@@ -46,7 +45,6 @@ class ExtensionSystemImpl : public ExtensionSystem {

LazyBackgroundTaskQueue* lazy_background_task_queue() override; // shared

InfoMap* info_map() override; // shared

EventRouter* event_router() override; // shared

- WarningService* warning_service() override;

Blacklist* blacklist() override; // shared

ErrorConsole* error_console() override;

InstallVerifier* install_verifier() override;

@@ -96,7 +94,6 @@ class ExtensionSystemImpl : public ExtensionSystem {

InfoMap* info_map();

LazyBackgroundTaskQueue* lazy_background_task_queue();

EventRouter* event_router();

- WarningService* warning_service();

ErrorConsole* error_console();

InstallVerifier* install_verifier();

QuotaService* quota_service();

@@ -134,8 +131,6 @@ class ExtensionSystemImpl : public ExtensionSystem {

scoped_ptr<ManagementPolicy> management_policy_;

// extension_info_map_ needs to outlive process_manager_.

scoped_refptr<InfoMap> extension_info_map_;

- scoped_ptr<WarningService> warning_service_;

- scoped_ptr<ExtensionWarningBadgeService> extension_warning_badge_service_;

scoped_ptr<ErrorConsole> error_console_;

scoped_ptr<InstallVerifier> install_verifier_;

scoped_ptr<QuotaService> quota_service_;