sky/engine/core/rendering/RenderBox.cpp - Issue 698613002: Remove border-fit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderBox.cpp

Issue 698613002: Remove border-fit. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderBox.cpp

diff --git a/sky/engine/core/rendering/RenderBox.cpp b/sky/engine/core/rendering/RenderBox.cpp

index 4146dd3e25396e47b50ee54a09a83674369079bb..151a3ab8189277eecda0423bfd008224b5c98fc4 100644

--- a/sky/engine/core/rendering/RenderBox.cpp

+++ b/sky/engine/core/rendering/RenderBox.cpp

@@ -1780,7 +1780,7 @@ void RenderBox::computeLogicalWidth(LogicalExtentComputedValues& computedValues)

// width. Use the width from the style context.

// FIXME: Account for block-flow in flexible boxes.

// https://bugs.webkit.org/show_bug.cgi?id=46418

- if (hasOverrideWidth() && (style()->borderFit() == BorderFitLines || parent()->isFlexibleBox())) {

+ if (hasOverrideWidth() && parent()->isFlexibleBox()) {

computedValues.m_extent = overrideLogicalContentWidth() + borderAndPaddingLogicalWidth();

return;

}