Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 698613002: Remove border-fit. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
Reviewers:
esprehn
CC:
abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove border-fit. This just lets you size an element to it's content. We should do this in a more generic way or let you override layout and do it yourself. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0c151213598970ee1ad6fd613b53d94a5ef9cb30

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -119 lines) Patch
M sky/engine/core/css/CSSComputedStyleDeclaration.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/css/CSSPrimitiveValueMappings.h View 1 chunk +0 lines, -30 lines 0 comments Download
M sky/engine/core/css/CSSProperties.in View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/CSSValueKeywords.in View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/core/css/parser/BisonCSSParser-in.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderBlockFlow.h View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderBlockFlow.cpp View 2 chunks +0 lines, -54 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderObject.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.h View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/style/RenderStyleConstants.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/style/StyleRareNonInheritedData.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/style/StyleRareNonInheritedData.cpp View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ojan
6 years, 1 month ago (2014-10-31 17:42:02 UTC) #2
esprehn
Your description is wrong, that's not what border-fit does, it changes how border-image works. I ...
6 years, 1 month ago (2014-10-31 17:44:38 UTC) #3
esprehn
lgtm, apparently this was already removed on trunk anyway.
6 years, 1 month ago (2014-10-31 17:50:00 UTC) #4
esprehn
On 2014/10/31 at 17:50:00, esprehn wrote: > lgtm, apparently this was already removed on trunk ...
6 years, 1 month ago (2014-10-31 17:50:14 UTC) #5
ojan
6 years, 1 month ago (2014-10-31 17:59:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0c151213598970ee1ad6fd613b53d94a5ef9cb30.

Powered by Google App Engine
This is Rietveld 408576698