Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 698553002: Split Blacklist from ExtensionSystem. (Closed)

Created:
6 years, 1 month ago by Reilly Grant (use Gerrit)
Modified:
6 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Split Blacklist from ExtensionSystem. This patch removes another service from ExtensionSystem that can easily be its own browser context keyed service. If the ExtensionPrefs dependency Blacklist can be removed it could be promoted to a true singleton. BUG= Committed: https://crrev.com/121e88992317117b8e1508ecc47436200b1bfaa3 Cr-Commit-Position: refs/heads/master@{#302496}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -58 lines) Patch
M chrome/browser/apps/ephemeral_app_launcher_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/blacklist.h View 3 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/extensions/blacklist.cc View 2 chunks +6 lines, -0 lines 0 comments Download
A chrome/browser/extensions/blacklist_factory.h View 1 chunk +37 lines, -0 lines 0 comments Download
A + chrome/browser/extensions/blacklist_factory.cc View 1 1 chunk +16 lines, -16 lines 0 comments Download
M chrome/browser/extensions/extension_install_checker.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_system_factory.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_system_impl.h View 1 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_system_impl.cc View 1 5 chunks +1 line, -12 lines 0 comments Download
M chrome/browser/extensions/test_extension_system.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/test_extension_system.cc View 1 3 chunks +1 line, -6 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/browser/extension_system.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M extensions/browser/mock_extension_system.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/mock_extension_system.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/shell/browser/shell_extension_system.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M extensions/shell/browser/shell_extension_system.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Reilly Grant (use Gerrit)
asargent@, please take a look.
6 years, 1 month ago (2014-10-31 17:04:40 UTC) #2
asargent_no_longer_on_chrome
typo in CL description: "has could removed" otherwise lgtm
6 years, 1 month ago (2014-11-03 18:39:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/698553002/20001
6 years, 1 month ago (2014-11-03 20:27:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/77032) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/82000) win_chromium_compile_dbg ...
6 years, 1 month ago (2014-11-03 20:32:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/698553002/40001
6 years, 1 month ago (2014-11-03 21:31:05 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
6 years, 1 month ago (2014-11-03 22:13:06 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 22:13:43 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/121e88992317117b8e1508ecc47436200b1bfaa3
Cr-Commit-Position: refs/heads/master@{#302496}

Powered by Google App Engine
This is Rietveld 408576698