Signing out forces the lock bit to be removed.

Signing out forces the lock bit to be removed.

Since sync may cause a profile to become signed out, we cannot assume
a signing out profile is unlocked. Thus, forcibly unlock it.

BUG=426174
Committed: https://crrev.com/0e26199c8913eaa1bfd341109a52c3f24e068ca4
Cr-Commit-Position: refs/heads/master@{#302427}

[Mike Lerman, 2014-10-31 14:45:02]

mlerman@chromium.org changed reviewers:
+ rogerta@chromium.org

[Mike Lerman, 2014-10-31 14:45:02]

Hi Roger,

Please take a look at this CL? Thanks.

Mike

[Roger Tawa OOO till Jul 10th, 2014-10-31 20:43:55]

lgtm

https://codereview.chromium.org/698543002/diff/1/chrome/browser/signin/chrome...
File chrome/browser/signin/chrome_signin_client.cc (right):

https://codereview.chromium.org/698543002/diff/1/chrome/browser/signin/chrome...
chrome/browser/signin/chrome_signin_client.cc:171:
cache.SetProfileSigninRequiredAtIndex(index, false);
Should calling SetLocalAuthCredentialsOfProfileAtIndex() with an empty string do
this automatically?

[Mike Lerman, 2014-11-03 01:44:53]

On 2014/10/31 20:43:55, Roger Tawa wrote:
> lgtm
> 
>
https://codereview.chromium.org/698543002/diff/1/chrome/browser/signin/chrome...
> File chrome/browser/signin/chrome_signin_client.cc (right):
> 
>
https://codereview.chromium.org/698543002/diff/1/chrome/browser/signin/chrome...
> chrome/browser/signin/chrome_signin_client.cc:171:
> cache.SetProfileSigninRequiredAtIndex(index, false);
> Should calling SetLocalAuthCredentialsOfProfileAtIndex() with an empty string
do
> this automatically?

I'm not inclined to. The ProfileInfoCache's Set* methods seem to include minimal
logic, unless it's directly related to the info_cache's self organization. Also,
this is the only place where we need to set LocalAuthCredentials and
SigninRequired at the same time; if there were more places in the code where
they were set together, I'd be inclined to link them in the info_cache's code,
but not at this point.

How's that sound?

[Roger Tawa OOO till Jul 10th, 2014-11-03 14:19:17]

Sgtm

On Sun, Nov 2, 2014, 20:44 null <mlerman@chromium.org> wrote:

> On 2014/10/31 20:43:55, Roger Tawa wrote:
> > lgtm
>
>
> https://codereview.chromium.org/698543002/diff/1/chrome/
> browser/signin/chrome_signin_client.cc
> > File chrome/browser/signin/chrome_signin_client.cc (right):
>
>
> https://codereview.chromium.org/698543002/diff/1/chrome/
> browser/signin/chrome_signin_client.cc#newcode171
> > chrome/browser/signin/chrome_signin_client.cc:171:
> > cache.SetProfileSigninRequiredAtIndex(index, false);
> > Should calling SetLocalAuthCredentialsOfProfileAtIndex() with an empty
> > string
> do
> > this automatically?
>
> I'm not inclined to. The ProfileInfoCache's Set* methods seem to include
> minimal
> logic, unless it's directly related to the info_cache's self organization.
> Also,
> this is the only place where we need to set LocalAuthCredentials and
> SigninRequired at the same time; if there were more places in the code
> where
> they were set together, I'd be inclined to link them in the info_cache's
> code,
> but not at this point.
>
> How's that sound?
>
> https://codereview.chromium.org/698543002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Mike Lerman, 2014-11-03 14:25:05]

The CQ bit was checked by mlerman@chromium.org

[commit-bot: I haz the power, 2014-11-03 14:25:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/698543002/1

[commit-bot: I haz the power, 2014-11-03 15:06:06]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-11-03 15:06:46]

Patchset 1 (id:??) landed as
https://crrev.com/0e26199c8913eaa1bfd341109a52c3f24e068ca4
Cr-Commit-Position: refs/heads/master@{#302427}