Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 698483003: Fix: Set Android to go back to CLD2. The CLD version should not have been updated in change 14d913,… (Closed)

Created:
6 years, 1 month ago by Andrew Hayden (chromium.org)
Modified:
6 years, 1 month ago
Reviewers:
Takashi Toyoshima, gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix: Set Android to go back to CLD2. The CLD version should not have been updated in change 14d913, but that change is otherwise correct. Code review where I missed this: codereview.chromium.org/461633002 This only breaks downstream builds that are still tied to CLD1, such as Chrome for Android. We shouldn't do the changeover to CLD2 without announcing first to chromium-dev. notry=true because this simply returns Android to CLD1, as it has always been., BUG= NOTRY=true TBR=toyoshim@chromium.org Committed: https://crrev.com/fe3b61660588dce1f1cee9ec2bb6c0b2e09f2303 Cr-Commit-Position: refs/heads/master@{#303710}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
gone
lgtm
6 years, 1 month ago (2014-11-11 20:12:35 UTC) #2
Andrew Hayden (chromium.org)
TBR=toyoshim, as FYI. Notes taken to talk to downstream infrastructure folks about ways to automate ...
6 years, 1 month ago (2014-11-11 20:22:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/698483003/1
6 years, 1 month ago (2014-11-11 20:23:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-11 20:24:53 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fe3b61660588dce1f1cee9ec2bb6c0b2e09f2303 Cr-Commit-Position: refs/heads/master@{#303710}
6 years, 1 month ago (2014-11-11 20:25:49 UTC) #8
Andrew Hayden (chromium.org)
6 years, 1 month ago (2014-11-11 21:27:32 UTC) #9
Message was sent while issue was closed.
For posterity, verified that this passed all tests in the waterfall:
http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/16741

Powered by Google App Engine
This is Rietveld 408576698