Issue 698463006: Revert of Hold the Pepper proxy lock for all Pepper GL calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 698463006: Revert of Hold the Pepper proxy lock for all Pepper GL calls. (Closed)

Created:
6 years, 1 month ago by kareng

Modified:
6 years, 1 month ago

Reviewers:
dmichael (off chromium), dmichael(do not use this one), Peng

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Revert of Hold the Pepper proxy lock for all Pepper GL calls. (patchset #3 id:40001 of https://codereview.chromium.org/692683003/) Reason for revert: causing huge crashes in canary. bug=429446 Original issue's description: > Hold the Pepper proxy lock for all Pepper GL calls. > > BUG=418651 > > Committed: https://crrev.com/057f7a69dd40c93550b375b4287dba70d719316a > Cr-Commit-Position: refs/heads/master@{#302303} TBR=dmichael@chromium.org,dmichael@google.com,penghuang@chromium.org NOTREECHECKS=true NOTRY=true BUG=418651 Committed: https://crrev.com/b44a1337142876b6a6a1b7019bcde806ef49040b Cr-Commit-Position: refs/heads/master@{#302391}

Created: 6 years, 1 month ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -26 lines)			Patch
M	ppapi/proxy/plugin_dispatcher.h	View	1 chunk	+4 lines, -7 lines	0 comments	Download
M	ppapi/proxy/plugin_dispatcher.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	ppapi/proxy/ppapi_command_buffer_proxy.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	ppapi/proxy/proxy_channel.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	ppapi/proxy/proxy_channel.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 4 (0 generated)

kareng

Created Revert of Hold the Pepper proxy lock for all Pepper GL calls.

6 years, 1 month ago (2014-11-01 19:05:38 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/698463006/1

6 years, 1 month ago (2014-11-01 19:06:00 UTC) #2

commit-bot: I haz the power

6 years, 1 month ago (2014-11-01 19:07:01 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/b44a1337142876b6a6a1b7019bcde806ef49040b
Cr-Commit-Position: refs/heads/master@{#302391}