Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 698433003: Desktop User Manager: Use new Material icons for "locked" and "supervised". (Closed)

Created:
6 years, 1 month ago by Marc Treib
Modified:
6 years, 1 month ago
CC:
chromium-reviews, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Desktop User Manager: Use new Material icons for "locked" and "supervised". Also, draw the white circle background in css (instead of having it baked into the icons). As a side-effect, this allows us to have multiple badges on the same profile. BUG=427435 Committed: https://crrev.com/6810771c9c624613f1d50577034db6c092ed1013 Cr-Commit-Position: refs/heads/master@{#302302}

Patch Set 1 #

Messages

Total messages: 11 (2 generated)
Marc Treib
bauerb@chromium.org: Please review changes in c/b/resources. noms@chromium.org: Please review changes in ui/login, and general sanity. ...
6 years, 1 month ago (2014-10-31 10:37:22 UTC) #2
Bernhard Bauer
lgtm
6 years, 1 month ago (2014-10-31 10:40:48 UTC) #3
Marc Treib
On 2014/10/31 10:40:48, Bernhard Bauer wrote: > lgtm Screenshots for reference: Before: https://drive.google.com/a/google.com/file/d/0BxTU2YPRG-lRQlZLLXJDbFBWOFk/view?usp=sharing After: https://drive.google.com/a/google.com/file/d/0BxTU2YPRG-lRTUkzbzQ3UDhOZ1k/view?usp=sharing
6 years, 1 month ago (2014-10-31 10:44:38 UTC) #4
Bernhard Bauer
I thought we can already do that for supervised users? On Fri, Oct 31, 2014, ...
6 years, 1 month ago (2014-10-31 10:47:43 UTC) #5
noms (inactive)
lgtm
6 years, 1 month ago (2014-10-31 14:01:45 UTC) #6
oshima
c/a/t lgtm
6 years, 1 month ago (2014-10-31 15:32:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/698433003/1
6 years, 1 month ago (2014-10-31 16:15:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 19:02:07 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 19:03:15 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6810771c9c624613f1d50577034db6c092ed1013
Cr-Commit-Position: refs/heads/master@{#302302}

Powered by Google App Engine
This is Rietveld 408576698