Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: gin/test/file_runner.cc

Issue 69843003: Implement Mojo message codec in JavaScript (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address Aaron's comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gin/test/file_runner.h ('k') | gin/test/gtest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gin/test/file_runner.cc
diff --git a/gin/test/file_runner.cc b/gin/test/file_runner.cc
index a343d6483cc33d376111c347cd8074ac3e749b4b..dd0ca66688653ddde456c1cc599c4fd0a080f2fd 100644
--- a/gin/test/file_runner.cc
+++ b/gin/test/file_runner.cc
@@ -27,28 +27,19 @@ base::FilePath GetModuleBase() {
FileRunnerDelegate::FileRunnerDelegate()
: ModuleRunnerDelegate(GetModuleBase()) {
+ AddBuiltinModule(GTest::kModuleName, GTest::GetTemplate);
}
FileRunnerDelegate::~FileRunnerDelegate() {
}
-void FileRunnerDelegate::DidCreateContext(Runner* runner) {
- ModuleRunnerDelegate::DidCreateContext(runner);
-
- v8::Handle<v8::Context> context = runner->context();
- ModuleRegistry* registry = ModuleRegistry::From(context);
-
- registry->AddBuiltinModule(runner->isolate(), "gtest",
- GetGTestTemplate(runner->isolate()));
-}
-
void FileRunnerDelegate::UnhandledException(Runner* runner,
TryCatch& try_catch) {
ModuleRunnerDelegate::UnhandledException(runner, try_catch);
EXPECT_FALSE(try_catch.HasCaught()) << try_catch.GetPrettyMessage();
}
-void RunTestFromFile(const base::FilePath& path, RunnerDelegate* delegate) {
+void RunTestFromFile(const base::FilePath& path, FileRunnerDelegate* delegate) {
ASSERT_TRUE(base::PathExists(path)) << path.LossyDisplayName();
std::string source;
ASSERT_TRUE(ReadFileToString(path, &source));
« no previous file with comments | « gin/test/file_runner.h ('k') | gin/test/gtest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698