Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: Source/bindings/templates/union.cpp

Issue 698423002: IDL union: nullable support (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/templates/union.h ('k') | Source/bindings/tests/idls/core/TestObject.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/templates/union.cpp
diff --git a/Source/bindings/templates/union.cpp b/Source/bindings/templates/union.cpp
index c3c89bc08244e92d004b49d1067455cfba42bd86..5ef84e1a767a246b5df7143c2df9c9fecf2c5e03 100644
--- a/Source/bindings/templates/union.cpp
+++ b/Source/bindings/templates/union.cpp
@@ -52,14 +52,12 @@ void {{container.cpp_class}}::trace(Visitor* visitor)
{% endif %}
void V8{{container.cpp_class}}::toImpl(v8::Isolate* isolate, v8::Handle<v8::Value> v8Value, {{container.cpp_class}}& impl, ExceptionState& exceptionState)
{
- {# FIXME: We don't follow the spec on handling null and undefined at this
- moment. Should be fixed once we implement all necessary conversion steps
- below. #}
if (v8Value.IsEmpty())
return;
{# The numbers in the following comments refer to the steps described in
http://heycam.github.io/webidl/#es-union
+ NOTE: Step 1 (null or undefined) is handled in *OrNull::toImpl()
FIXME: Implement all necessary steps #}
{# 3. Platform objects (interfaces) #}
{% for interface in container.interface_types %}
« no previous file with comments | « Source/bindings/templates/union.h ('k') | Source/bindings/tests/idls/core/TestObject.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698