Source/bindings/scripts/code_generator_v8.py - Issue 698423002: IDL union: nullable support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/code_generator_v8.py

Issue 698423002: IDL union: nullable support (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/code_generator_v8.py

diff --git a/Source/bindings/scripts/code_generator_v8.py b/Source/bindings/scripts/code_generator_v8.py

index 15d9977f5a350cdf85b7bd8279a6698b123c823d..b34cfcb09506f8c5a8bc63c0d58bf4c0cf42c74e 100644

--- a/Source/bindings/scripts/code_generator_v8.py

+++ b/Source/bindings/scripts/code_generator_v8.py

@@ -269,8 +269,7 @@ class CodeGeneratorUnionType(object):

header_template = self.jinja_env.get_template('union.h')

cpp_template = self.jinja_env.get_template('union.cpp')

template_context = v8_union.union_context(

- sorted(union_types, key=lambda union_type: union_type.name),

- self.interfaces_info)

+ union_types, self.interfaces_info)

template_context['code_generator'] = module_pyname

capitalized_component = self.target_component.capitalize()

template_context['header_filename'] = 'bindings/%s/v8/UnionTypes%s.h' % (

« no previous file with comments | « no previous file | Source/bindings/scripts/idl_types.py » ('j') | no next file with comments »