Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: Source/bindings/tests/idls/core/TestObject.idl

Issue 698423002: IDL union: nullable support (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/idls/core/TestObject.idl
diff --git a/Source/bindings/tests/idls/core/TestObject.idl b/Source/bindings/tests/idls/core/TestObject.idl
index 542f46438e10618d2d7e5911afd7547f75efda5c..ba7d88c3d74cf67bc6dcbca10b63cbc66bec9fcb 100644
--- a/Source/bindings/tests/idls/core/TestObject.idl
+++ b/Source/bindings/tests/idls/core/TestObject.idl
@@ -157,6 +157,8 @@ interface TestObject {
attribute EventHandler eventHandlerAttribute;
// Union types
attribute (double or DOMString) doubleOrStringAttribute;
+ attribute (double or DOMString)? doubleOrStringOrNullAttribute;
+ attribute (double? or DOMString) doubleOrNullStringAttribute;
// Extended attributes
[LogActivity, LogAllWorlds] attribute long activityLoggingAccessForAllWorldsLongAttribute;
@@ -356,7 +358,9 @@ interface TestObject {
(TestInterfaceWillBeGarbageCollected or TestDictionary) testInterfaceWillBeGarbageCollectedOrTestDictionaryMethod();
(boolean or DOMString or unrestricted double) booleanOrDOMStringOrUnrestrictedDoubleMethod();
(TestInterface or long) testInterfaceOrLongMethod();
- void voidMethodDOMStringOrDouble((DOMString or double) arg);
+ void voidMethodDoubleOrDOMString((double or DOMString) arg);
bashi 2014/11/07 10:07:53 These method name were wrong (my bad).
Jens Widell 2014/11/07 10:58:19 Technically they still are. :-) Should be "voidMe
bashi 2014/11/08 07:10:34 Oops... Done:)
+ void voidMethodDoubleOrDOMStringOrNull((double or DOMString)? arg);
+ void voidMethodDoubleOrNullOrDOMString((double? or DOMString) arg);
void voidMethodDOMStringOrArrayBufferOrArrayBufferView((DOMString or ArrayBuffer or ArrayBufferView) arg);
// Currently only used on interface type arguments
void voidMethodTestInterfaceEmptyOrNullArg(TestInterfaceEmpty? nullableTestInterfaceEmptyArg);

Powered by Google App Engine
This is Rietveld 408576698