Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 698383003: [turbofan] Use load/store indexes as 64-bit registers on arm64. (Closed)

Created:
6 years, 1 month ago by baptiste.afsa1
Modified:
6 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Use load/store indexes as 64-bit registers on arm64. Since r25024 load/store indexes are 64-bit value but arm64 backend was still treating them as 32-bit value. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25144

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
baptiste.afsa1
PTAL
6 years, 1 month ago (2014-11-05 11:34:22 UTC) #1
Benedikt Meurer
lgtm
6 years, 1 month ago (2014-11-05 11:34:52 UTC) #2
baptiste.afsa1
6 years, 1 month ago (2014-11-05 11:36:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 25144 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698