webcrypto: Add ECDSA algorithm (chromium-side)

content/child/webcrypto/test/ecdsa_unittest.cc

Index: content/child/webcrypto/test/ecdsa_unittest.cc
diff --git a/content/child/webcrypto/test/ecdsa_unittest.cc b/content/child/webcrypto/test/ecdsa_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..6842d16914182d1aaac7e3a8b6f05d56d57ffa9f
--- /dev/null
+++ b/content/child/webcrypto/test/ecdsa_unittest.cc
@@ -0,0 +1,322 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/stl_util.h"
+#include "content/child/webcrypto/algorithm_dispatch.h"
+#include "content/child/webcrypto/crypto_data.h"
+#include "content/child/webcrypto/jwk.h"
+#include "content/child/webcrypto/status.h"
+#include "content/child/webcrypto/test/test_helpers.h"
+#include "content/child/webcrypto/webcrypto_util.h"
+#include "third_party/WebKit/public/platform/WebCryptoAlgorithmParams.h"
+#include "third_party/WebKit/public/platform/WebCryptoKeyAlgorithm.h"
+
+namespace content {
+
+namespace webcrypto {
+
+namespace {
+
+bool SupportsEcdsa() {
+#if defined(USE_OPENSSL)
+  return true;
+#else
+  LOG(ERROR) << "Skipping ECDSA test because unsupported";
+  return false;
+#endif
+}
+
+// This is essentially a duplication of the curve name parsing done by Blink,
+// so tests can use the same names in data files.
+blink::WebCryptoNamedCurve GetCurveNameFromJsonTest(
+    const base::DictionaryValue* test) {
+  std::string curve_str;
+  if (!test->GetString("curve", &curve_str)) {
+    EXPECT_TRUE(false) << "Missing \"curve\" parameter";
+  }
+
+  if (curve_str == "P-256")
+    return blink::WebCryptoNamedCurveP256;
+  if (curve_str == "P-384")
+    return blink::WebCryptoNamedCurveP384;
+  if (curve_str == "P-521")
+    return blink::WebCryptoNamedCurveP521;
+  else
+    EXPECT_TRUE(false) << "Unrecognized curve name: " << curve_str;

[davidben, 2014/11/07 00:17:21]

Probably ADD_FAILURE() instead of EXPECT_TRUE(false)

[eroman, 2014/11/11 01:26:27]

Done.

+
+  return blink::WebCryptoNamedCurveP384;
+}
+
+blink::WebCryptoAlgorithm CreateEcdsaKeyGenAlgorithm(
+    blink::WebCryptoNamedCurve named_curve) {
+  return blink::WebCryptoAlgorithm::adoptParamsAndCreate(
+      blink::WebCryptoAlgorithmIdEcdsa,
+      new blink::WebCryptoEcKeyGenParams(named_curve));
+}
+
+blink::WebCryptoAlgorithm CreateEcdsaImportAlgorithm(
+    blink::WebCryptoNamedCurve named_curve) {
+  return CreateEcImportAlgorithm(blink::WebCryptoAlgorithmIdEcdsa, named_curve);
+}
+
+blink::WebCryptoAlgorithm CreateEcdsaAlgorithm(
+    blink::WebCryptoAlgorithmId hash_id) {
+  return blink::WebCryptoAlgorithm::adoptParamsAndCreate(
+      blink::WebCryptoAlgorithmIdEcdsa,
+      new blink::WebCryptoEcdsaParams(CreateAlgorithm(hash_id)));
+}
+
+// Generates some ECDSA key pairs. Validates basic properties on the keys, and
+// ensures the serialized key (as JWK) is unique. This test does nothing to
+// ensure that the keys are otherwise usable (by trying to sign/verify with
+// them).
+TEST(WebCryptoEcdsaTest, GenerateKeyIsRandom) {
+  if (!SupportsEcdsa())
+    return;
+
+  blink::WebCryptoNamedCurve named_curve = blink::WebCryptoNamedCurveP256;
+
+  std::vector<std::vector<uint8_t>> serialized_keys;
+
+  // Generate a small sample of keys.
+  for (int j = 0; j < 4; ++j) {
+    blink::WebCryptoKey public_key;
+    blink::WebCryptoKey private_key;
+
+    ASSERT_EQ(Status::Success(),
+              GenerateKeyPair(CreateEcdsaKeyGenAlgorithm(named_curve), true, 0,
+                              &public_key, &private_key));
+
+    // Basic sanity checks on the generated key pair.
+    EXPECT_EQ(blink::WebCryptoKeyTypePublic, public_key.type());
+    EXPECT_EQ(blink::WebCryptoKeyTypePrivate, private_key.type());
+    EXPECT_EQ(named_curve, public_key.algorithm().ecParams()->namedCurve());
+    EXPECT_EQ(named_curve, private_key.algorithm().ecParams()->namedCurve());
+
+    // Export the key pair to JWK.
+    std::vector<uint8_t> key_bytes;
+    ASSERT_EQ(Status::Success(),
+              ExportKey(blink::WebCryptoKeyFormatJwk, public_key, &key_bytes));
+    serialized_keys.push_back(key_bytes);
+
+    ASSERT_EQ(Status::Success(),
+              ExportKey(blink::WebCryptoKeyFormatJwk, private_key, &key_bytes));
+    serialized_keys.push_back(key_bytes);
+  }
+
+  // Ensure all entries in the key sample set are unique. This is a simplistic
+  // estimate of whether the generated keys appear random.
+  EXPECT_FALSE(CopiesExist(serialized_keys));
+}
+
+// Verify that ECDSA signatures are probabilistic. Signing the same message two
+// times should yield different signatures. However both signatures should
+// verify correctly.
+TEST(WebCryptoEcdsaTest, SignatureIsRandom) {
+  if (!SupportsEcdsa())
+    return;
+
+  // Import a public and private keypair from "ec_private_keys.json". It doesn't
+  // really matter which one is used since they are all valid. In this case
+  // using the first one.
+  scoped_ptr<base::ListValue> private_keys;
+  ASSERT_TRUE(ReadJsonTestFileToList("ec_private_keys.json", &private_keys));
+  const base::DictionaryValue* key_dict;
+  ASSERT_TRUE(private_keys->GetDictionary(0, &key_dict));
+  blink::WebCryptoNamedCurve curve = GetCurveNameFromJsonTest(key_dict);
+  const base::DictionaryValue* key_jwk;
+  ASSERT_TRUE(key_dict->GetDictionary("jwk", &key_jwk));
+
+  blink::WebCryptoKey private_key;
+  ASSERT_EQ(
+      Status::Success(),
+      ImportKeyJwkFromDict(*key_jwk, CreateEcdsaImportAlgorithm(curve), true,
+                           blink::WebCryptoKeyUsageSign, &private_key));
+
+  // Erase the "d" member so the private key JWK can be used to import the
+  // public key (WebCrypto doesn't provide a mechanism for importing a public
+  // key given a private key).
+  scoped_ptr<base::DictionaryValue> key_jwk_copy(key_jwk->DeepCopy());
+  key_jwk_copy->Remove("d", NULL);
+  blink::WebCryptoKey public_key;
+  ASSERT_EQ(Status::Success(),
+            ImportKeyJwkFromDict(*key_jwk_copy.get(),
+                                 CreateEcdsaImportAlgorithm(curve), true,
+                                 blink::WebCryptoKeyUsageVerify, &public_key));
+
+  // Sign twice
+  std::vector<uint8_t> message(10);
+  blink::WebCryptoAlgorithm algorithm =
+      CreateEcdsaAlgorithm(blink::WebCryptoAlgorithmIdSha1);
+
+  std::vector<uint8_t> signature1;
+  std::vector<uint8_t> signature2;
+  ASSERT_EQ(Status::Success(),
+            Sign(algorithm, private_key, CryptoData(message), &signature1));
+  ASSERT_EQ(Status::Success(),
+            Sign(algorithm, private_key, CryptoData(message), &signature2));
+
+  // The two signatures should be different.
+  EXPECT_NE(CryptoData(signature1), CryptoData(signature2));
+
+  // And both should be valid signatures which can be verified.
+  bool signature_matches;
+  ASSERT_EQ(Status::Success(),
+            Verify(algorithm, public_key, CryptoData(signature1),
+                   CryptoData(message), &signature_matches));
+  EXPECT_TRUE(signature_matches);
+  ASSERT_EQ(Status::Success(),
+            Verify(algorithm, public_key, CryptoData(signature2),
+                   CryptoData(message), &signature_matches));
+  EXPECT_TRUE(signature_matches);
+}
+
+// Tests verify() for ECDSA using an assortment of keys, curves and hashes.
+// These tests also include expected failures for bad signatures and keys.
+TEST(WebCryptoEcdsaTest, VerifyKnownAnswer) {
+  if (!SupportsEcdsa())
+    return;
+
+  scoped_ptr<base::ListValue> tests;
+  ASSERT_TRUE(ReadJsonTestFileToList("ecdsa.json", &tests));
+
+  for (size_t test_index = 0; test_index < tests->GetSize(); ++test_index) {
+    SCOPED_TRACE(test_index);
+
+    const base::DictionaryValue* test;
+    ASSERT_TRUE(tests->GetDictionary(test_index, &test));
+
+    // Import the public key.
+    blink::WebCryptoNamedCurve curve = GetCurveNameFromJsonTest(test);
+    blink::WebCryptoKeyFormat key_format = GetKeyFormatFromJsonTestCase(test);
+    std::vector<uint8_t> key_data =
+        GetKeyDataFromJsonTestCase(test, key_format);
+
+    // If the test didn't specify an error, that implies it expects success.
+    std::string expected_error = "Success";
+    test->GetString("error", &expected_error);
+
+    // Import the public key.
+    blink::WebCryptoKey key;
+    Status status = ImportKey(key_format, CryptoData(key_data),
+                              CreateEcdsaImportAlgorithm(curve), true,
+                              blink::WebCryptoKeyUsageVerify, &key);
+    ASSERT_EQ(expected_error, StatusToString(status));
+    if (status.IsError())
+      continue;
+
+    // Basic sanity checks on the imported public key.
+    EXPECT_EQ(blink::WebCryptoKeyTypePublic, key.type());
+    EXPECT_EQ(blink::WebCryptoKeyUsageVerify, key.usages());
+    EXPECT_EQ(curve, key.algorithm().ecParams()->namedCurve());
+
+    // Now try to verify the given message and signature.
+    std::vector<uint8_t> message = GetBytesFromHexString(test, "msg");
+    std::vector<uint8_t> signature = GetBytesFromHexString(test, "sig");
+    blink::WebCryptoAlgorithm hash = GetDigestAlgorithm(test, "hash");
+
+    bool verify_result;
+    status = Verify(CreateEcdsaAlgorithm(hash.id()), key, CryptoData(signature),
+                    CryptoData(message), &verify_result);
+    ASSERT_EQ(expected_error, StatusToString(status));
+    if (status.IsError())
+      continue;
+
+    // If no error was expected, the verification's boolean must match
+    // "verify_result" for the test.
+    bool expected_result = false;
+    ASSERT_TRUE(test->GetBoolean("verify_result", &expected_result));
+    EXPECT_EQ(expected_result, verify_result);
+  }
+}
+
+// Tests importing and exporting of EC private keys, using both JWK and PKCS8
+// formats.
+//
+// The test imports a key first using JWK, and then exporting it to JWK and
+// PKCS8. It does the same thing using PKCS8 as the original source of truth.
+TEST(WebCryptoEcdsaTest, ImportExportPrivateKey) {
+  if (!SupportsEcdsa())
+    return;
+
+  scoped_ptr<base::ListValue> tests;
+  ASSERT_TRUE(ReadJsonTestFileToList("ec_private_keys.json", &tests));
+
+  for (size_t test_index = 0; test_index < tests->GetSize(); ++test_index) {
+    SCOPED_TRACE(test_index);
+
+    const base::DictionaryValue* test;
+    ASSERT_TRUE(tests->GetDictionary(test_index, &test));
+
+    blink::WebCryptoNamedCurve curve = GetCurveNameFromJsonTest(test);
+    const base::DictionaryValue* jwk_dict;
+    EXPECT_TRUE(test->GetDictionary("jwk", &jwk_dict));
+    std::vector<uint8_t> jwk_bytes = MakeJsonVector(*jwk_dict);
+    std::vector<uint8_t> pkcs8_bytes = GetBytesFromHexString(test, "pkcs8");
+
+    // -------------------------------------------------
+    // Test from JWK, and then export to {JWK, PKCS8}
+    // -------------------------------------------------
+
+    // Import the key using JWK
+    blink::WebCryptoKey key;
+    ASSERT_EQ(Status::Success(),
+              ImportKey(blink::WebCryptoKeyFormatJwk, CryptoData(jwk_bytes),
+                        CreateEcdsaImportAlgorithm(curve), true,
+                        blink::WebCryptoKeyUsageSign, &key));
+
+    // Export the key as JWK
+    std::vector<uint8_t> exported_bytes;
+    ASSERT_EQ(Status::Success(),
+              ExportKey(blink::WebCryptoKeyFormatJwk, key, &exported_bytes));
+
+    // NOTE: The exported bytes can't be directly compared to jwk_bytes because
+    // the exported JWK differs from the inported one. In particular it contains

[davidben, 2014/11/07 00:17:21]

s/inports/imported/

[eroman, 2014/11/11 01:26:27]

Done.

+    // extra properties for extractability and key_ops.
+    //
+    // Verification is instead done by using the first exported JWK bytes as the
+    // expectation.
+    jwk_bytes = exported_bytes;
+    ASSERT_EQ(Status::Success(),
+              ImportKey(blink::WebCryptoKeyFormatJwk, CryptoData(jwk_bytes),
+                        CreateEcdsaImportAlgorithm(curve), true,
+                        blink::WebCryptoKeyUsageSign, &key));
+
+    // Export the key as JWK (again)
+    ASSERT_EQ(Status::Success(),
+              ExportKey(blink::WebCryptoKeyFormatJwk, key, &exported_bytes));
+    EXPECT_EQ(CryptoData(jwk_bytes), CryptoData(exported_bytes));
+
+    // Export the key as PKCS8
+    ASSERT_EQ(Status::Success(),
+              ExportKey(blink::WebCryptoKeyFormatPkcs8, key, &exported_bytes));
+    EXPECT_EQ(CryptoData(pkcs8_bytes), CryptoData(exported_bytes));
+
+    // -------------------------------------------------
+    // Test from PKCS8, and then export to {JWK, PKCS8}
+    // -------------------------------------------------
+
+    // Import the key using PKCS8
+    ASSERT_EQ(Status::Success(),
+              ImportKey(blink::WebCryptoKeyFormatPkcs8, CryptoData(pkcs8_bytes),
+                        CreateEcdsaImportAlgorithm(curve), true,
+                        blink::WebCryptoKeyUsageSign, &key));
+
+    // Export the key as PKCS8
+    ASSERT_EQ(Status::Success(),
+              ExportKey(blink::WebCryptoKeyFormatPkcs8, key, &exported_bytes));
+    EXPECT_EQ(CryptoData(pkcs8_bytes), CryptoData(exported_bytes));
+
+    // Export the key as JWK
+    ASSERT_EQ(Status::Success(),
+              ExportKey(blink::WebCryptoKeyFormatJwk, key, &exported_bytes));
+    EXPECT_EQ(CryptoData(jwk_bytes), CryptoData(exported_bytes));
+  }
+}
+
+}  // namespace
+
+}  // namespace webcrypto
+
+}  // namespace content